From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent Date: Mon, 08 Jul 2019 18:22:12 +0200 Message-ID: References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> <87sgrhz9e3.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69071"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36341@debbugs.gnu.org, Deus Max To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 08 18:29:01 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkWVg-000Has-1b for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 18:29:00 +0200 Original-Received: from localhost ([::1]:43260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkWQ0-0004Sm-O1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 12:23:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47269) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkWPv-0004SR-8H for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 12:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkWPu-0003jy-6P for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 12:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkWPu-0003jd-2k for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 12:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkWPt-0002MQ-TP for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 12:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36341 X-GNU-PR-Package: emacs Original-Received: via spool by 36341-submit@debbugs.gnu.org id=B36341.15626029418972 (code B ref 36341); Mon, 08 Jul 2019 16:23:01 +0000 Original-Received: (at 36341) by debbugs.gnu.org; 8 Jul 2019 16:22:21 +0000 Original-Received: from localhost ([127.0.0.1]:59374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkWPF-0002Ke-3i for submit@debbugs.gnu.org; Mon, 08 Jul 2019 12:22:21 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:58188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkWPA-0002KP-Ux for 36341@debbugs.gnu.org; Mon, 08 Jul 2019 12:22:19 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkWP6-0003HL-KY; Mon, 08 Jul 2019 18:22:15 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUCDDPo6NwQG0ALFTsA Bi3+/u4GEDY+R2UazpW6AAACZklEQVQ4jYWUQW/bMAyFCTlQzj0IuXpUZ181qVCuxmLk7oPhq2IX 6rVzmunv70lxtw4bNgaGDH0mH8lQoodhUOMw/mGk/tz7D3hQGX3Aw/2dmLlNKT3AxuGQDqmYGqnP tuuqGPfjtOs3+7yBYl/H6Smvkvb+d6Am5/t9wuv500hdiPE5xFOIs5qO6bF9eez77ksGPhLgBt5S egO4jHTW1lpttbazGub18bpu4KPGYNmIFqmdEerEPLN2FosazHN3TLwroFuiW5bFOWcBeseJeScR qotxwQ+WPSTbdLVPFdI9QxptwQOPWnznlrmWCNVTsR1JAVA1dmVuMjizZfhoLADGaG64yhpnSDu7 aOetmsyTEfzKp03cOY+sFoAmaAFf2VxKqDULwtTExPPKwmiAEwpAo0q6E1dNvLJ4nS+l8pyry+lm EFamq8gaqMNtWR1YNIGbijkDHzeDBz4Irq5YbHVwebJ4srqx87Et6cq7QwXxNrkgAh3TReVeZXnH 1qqDrT0JQ41+GUliV5fEIO6pocWQkceRKJZYstRhgiG/gRP/NLSEsGsoZtDdpcO9V1STDxSpLVOC At1dI4OAaaJjqcOWOnQJVUuTwYuijqSUIbcR4hq6MSIUwPld2ubKo8FH+KePahP3Po/PpGUtKYea 4eFcg3lz7Fz2qKtfwOp7D7UaWCNOQCiAvoN+Hh+SAGxFTdYUj/vwoI76NvB+5dC5uRbwiKH0ffHx NmixdvCvwpKBlNFXfvHhNukYUBAiO1XOhw8aUnQbXsu45gOq6DmfReZyuIf0LW2mKJ/893vh4/Xx r7vk7+AHYDoITYamAOAAAAAASUVORK5CYII= In-Reply-To: <87sgrhz9e3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 07 Jul 2019 16:56:36 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162338 Archived-At: Eric Abrahamsen writes: > I think `gnus-group-set-info' is the only place that happens, so it > isn't too terrible to just explicitly set both hashtable and alist in > that function. I've attached the commit that does that. Sounds good -- please apply. > My plan for avoiding this class of errors in the future is to change the > representation of Gnus groups from lists to EIEIO objects. Then > `gnus-newsrc-alist' would merely be a disk serialization format, and the > hashtable would be the source of authority. That would also make the > "dummy.group" unnecessary. But let's see if I get there, and if the > changes are accepted... The whole point of that awkward structure is to allow inserting/removing/updating groups from the list-of-subscribed-groups as an O(1) operation. Updating is still fine as O(1) with just a hash table, but without the point-at-the-previous-element list, you can't remove the elements, or add new elements before the group, as an O(1) thing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no