From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#35969: 26.2, Excorporate Date: Thu, 15 Aug 2019 23:40:55 -0400 Message-ID: References: <87ftml295d.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122462"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Collin Day , 35969-done@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 05:42:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyT81-000Vjq-1W for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 05:42:13 +0200 Original-Received: from localhost ([::1]:48934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyT7z-0005c9-AT for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 23:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39575) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyT7s-0005bu-5F for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 23:42:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyT7r-00058I-6W for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 23:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyT7q-00057Z-N6 for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 23:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyT7q-0001n1-IM for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 23:42:02 -0400 Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 03:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35969 X-GNU-PR-Package: emacs Mail-Followup-To: 35969@debbugs.gnu.org, fitzsim@fitzsim.org, dcday137@gmail.com Original-Received: via spool by 35969-done@debbugs.gnu.org id=D35969.15659268676809 (code D ref 35969); Fri, 16 Aug 2019 03:42:02 +0000 Original-Received: (at 35969-done) by debbugs.gnu.org; 16 Aug 2019 03:41:07 +0000 Original-Received: from localhost ([127.0.0.1]:52874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyT6w-0001ll-U2 for submit@debbugs.gnu.org; Thu, 15 Aug 2019 23:41:07 -0400 Original-Received: from mail-io1-f46.google.com ([209.85.166.46]:40082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyT6t-0001l6-Ni for 35969-done@debbugs.gnu.org; Thu, 15 Aug 2019 23:41:05 -0400 Original-Received: by mail-io1-f46.google.com with SMTP id t6so3584145ios.7 for <35969-done@debbugs.gnu.org>; Thu, 15 Aug 2019 20:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PV3yItgnKtWAI+3d+CVOBdBoE0+ldLT8iluEB1xHDt4=; b=FsjZeHDzn4kEdqgQ0y4929zYfWrSNa779uXVNP4dcWPI3KwRaVVetNJ9VK61xwHuic H7vpEp/yvkFSS88bFmc58yCw3lOxVqEO7/rwJOMSl3Rbi2ojrZIn3LHPgZdKhwTqemhb 7CiJpdQrvHahX6AnLzocY+z5h29ykSlkSxtxzMO9wK1n3jcDz9gllb2E5wLmmxI845Gg u2qCJqx5TeJU0hUKfHAelq4DDAgqA+GPYGl9/CbAADD6XdtfoV7dhTBL06BgcGkkV8rJ yNSCjMGP+EvA7dn9HnBLbHGx9VBxBzjYg7IRfBqdeIcm0oc66YaA5CGY+Gmco+jHniqw jWSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PV3yItgnKtWAI+3d+CVOBdBoE0+ldLT8iluEB1xHDt4=; b=dEwkJSSNORgRErMWaJ6wY3Baas2zCE1EHUQSF0JjkZzxrgd/p7dtIo1ADQ9MgjQ1JJ RoXk2uWTZ38C0Mo+dtjYnFNl6JBhY8kCvYGRcM1OtIMvAEtprMXYGTIpncgZxxb2wOnN G5AcO+DOWLQXWjk2dVn6seD2fVOpWsjTGVrCdk6g6jwiatgusWiJZjdxeV0IoCQ5s/C1 qUu2tIZnu3XF8wWrXVTePUoO+LpgmAuNmU2rD7DcgiT8u6tYwfAll/N8dgxclY3YD6JR 3koSzayYIO2t4WosW7X0GV/sDQp4DRGovtN8ZD+Adsd0HC2UQIUOL1AxhYpJ4IFhEWeK u9Ag== X-Gm-Message-State: APjAAAUa850izD0rc/4ny76AzO8clNa2kfnK0cB5/UbOwaIkc3vlRmT+ vH5wEHZfY7WKZUiLdTFuYmkB9407+Xc= X-Google-Smtp-Source: APXvYqzXE3wi7fSJUXSPlIh+UBXlBxgcaxOG2/Rt4dqvFLOxwnL3H3+Nt3nKYB59SErgyBhXJL8vig== X-Received: by 2002:a5d:934c:: with SMTP id i12mr9436661ioo.203.1565926857713; Thu, 15 Aug 2019 20:40:57 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id m25sm3251333ion.35.2019.08.15.20.40.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2019 20:40:56 -0700 (PDT) In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 31 Jul 2019 21:58:22 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165178 Archived-At: Thomas Fitzsimmons writes: > Andreas Schwab writes: > >> On Jul 31 2019, Thomas Fitzsimmons wrote: >> >>> Andreas, do you have a test case that patch A fixed, and if so, can >>> you retest with the proposed fix? >> >> Any https request over proxy will do. > > OK, I tested the attached patch; it works for a request to an uncached > HTTPS website, and it works for Excorporate accessing an HTTPS server. > > I moved the URL form logic to url-http-create-request because that > function refers to using-proxy (set to url-http-proxy on entry) in > multiple places, not just during URL recreation. When > url-https-proxy-after-change-function was setting using-proxy to nil for > the entire duration of the url-http-create-request, it was interfering > with "Connection" handling later in the function: > > "Connection: " (if (or using-proxy > (not url-http-attempt-keepalives)) > "close" "keep-alive") > > Does this look OK to push to master? I didn't hear any objections, so I pushed the change. Thanks, Thomas