From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs Subject: bug#53810: 29.0.50; Incorrect docstring for ietf-drums-get-comment Date: Sat, 05 Feb 2022 18:51:45 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11208"; mail-complaints-to="usenet@ciao.gmane.io" To: 53810@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 06 00:54:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGUsk-0002gS-3A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 00:54:18 +0100 Original-Received: from localhost ([::1]:50796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGUsj-0006tb-4M for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Feb 2022 18:54:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGUqY-000423-8o for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGUqX-00065S-Vh for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:52:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGUqX-0001q7-Qh for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Feb 2022 23:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53810 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16441051177059 (code B ref -1); Sat, 05 Feb 2022 23:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Feb 2022 23:51:57 +0000 Original-Received: from localhost ([127.0.0.1]:35935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUqT-0001pn-6P for submit@debbugs.gnu.org; Sat, 05 Feb 2022 18:51:57 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:48196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUqR-0001pf-BN for submit@debbugs.gnu.org; Sat, 05 Feb 2022 18:51:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGUqR-0003jE-31 for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:51:55 -0500 Original-Received: from rgrjr.com ([69.164.211.47]:55632) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGUqP-00063y-BH for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:51:54 -0500 Original-Received: from rgrjr.com (c-73-16-206-7.hsd1.ma.comcast.net [73.16.206.7]) by rgrjr.com (Postfix on openSUSE) with ESMTP id 4F7101D6BAE for ; Sat, 5 Feb 2022 23:52:02 +0000 (UTC) Original-Received: from orion.rgrjr.com (orion.rgrjr.com [192.168.0.3]) by scorpio.rgrjr.com (Postfix on openSUSE GNU/Linux) with ESMTP id ADCD25FEC6; Sat, 5 Feb 2022 18:51:51 -0500 (EST) Received-SPF: none client-ip=69.164.211.47; envelope-from=rogers@rgrjr.com; helo=rgrjr.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226116 Archived-At: In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2022-02-02 built on orion Repository revision: ed13b0d0f427df333f8e1f9a24015c354da4c62f Repository branch: rgr-ietf-drums-date Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: openSUSE Leap 15.3 In master as of d34dd869d2, doing (ietf-drums-get-comment "random (comment) (string)") returns "string", whereas the docstring says it returns the content of the first comment. The documentation for both ietf-drums-get-comment and mail-header-get-comment say "last"; perusing the code (only ietf-drums-get-comment is actually called) also shows that the last one is what callers expect. -- Bob Rogers http://www.rgrjr.com/ >From d1c9098ddfe0a913f8c20606347e334ca06dd9d3 Mon Sep 17 00:00:00 2001 From: Bob Rogers Date: Sat, 5 Feb 2022 18:27:58 -0500 Subject: [PATCH] ; Correct the ietf-drums-get-comment docstring * lisp/mail/ietf-drums.el (ietf-drums-get-comment): We really return the last comment. --- lisp/mail/ietf-drums.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/mail/ietf-drums.el b/lisp/mail/ietf-drums.el index 952707226f..fd9cb6abb7 100644 --- a/lisp/mail/ietf-drums.el +++ b/lisp/mail/ietf-drums.el @@ -150,7 +150,7 @@ ietf-drums-remove-whitespace (buffer-string)))) (defun ietf-drums-get-comment (string) - "Return the first comment in STRING." + "Return the last comment in STRING." (with-temp-buffer (ietf-drums-init string) (let (result c) -- 2.34.1