From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 63290@debbugs.gnu.org
Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...))
Date: Wed, 16 Aug 2023 11:16:32 -0400 [thread overview]
Message-ID: <m3edk3qapb.fsf@fitzsim.org> (raw)
In-Reply-To: <08306097-a6d2-ffbe-0991-31afbb71c037@gmail.com> (Mauro Aranda's message of "Tue, 15 Aug 2023 19:46:35 -0300")
Hi Mauro,
Mauro Aranda <maurooaranda@gmail.com> writes:
> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>
>> Mauro Aranda <maurooaranda@gmail.com> writes:
>>>> Can you try this patch with: M-x package-install RET
>>>> excorporate RET Then: M-x customize-variable RET
>>>> excorporate-configuration RET then select "Value Menu" and 3,
>>>> which is "EWS URL OAuth 2.0 settings (no autodiscovery)".
>>>> With your wis-edit.el patch applied I still get empty values
>>>> for: INS DEL Argument name: Argument value:
>>>> and: INS DEL OAuth 2.0 setting name: OAuth
>>>> 2.0 setting value: and when I apply the setting the value
>>>> contains: (... (... (#1# . #1#)) (#1# . #1#)) Maybe this is
>>>> a more complicated case than the test case I provided (which
>>>> does now work for me with your patch)?
>>> I think this ammended patch fixes it. Since we want
>>> widget-list-default-get to respect a nil :value property, the
>>> alist widget needs to be modified so that its default value is
>>> nil.
>>
>> With the updated patch, when I select "EWS URL OAuth 2.0
>> settings (no autodiscovery)", all the widgets are disabled.
>> The blank values are no longer added though. However, if I
>> then set the value, without configuring anything,
>> excorporate-configuration stays nil. So I don't think the patch
>> is correct yet.
>
> So, in case the :value is missing for the alist widget, we want
> to compute the default-value with the :options, and without
> including the editable-list.
>
> Hopefully the attached patch is 100% correct now. I did try it
> with excorporate-configuration and I think it works OK, but
> please give it yourself a try. And thank you for your patience.
Yes, after applying this patch, I retried the test case and
excorporate-configuration and both behave as I was originally
expecting them to; no stray structures upon setting the value.
Thank you for all your work on this and the comprehensive test
cases. Feel free to close this bug report once the patch is
pushed.
Thanks,
Thomas
next prev parent reply other threads:[~2023-08-16 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 6:02 bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Thomas Fitzsimmons
2023-07-16 13:15 ` Mauro Aranda
2023-07-17 2:37 ` Thomas Fitzsimmons
2023-08-09 12:19 ` Mauro Aranda
2023-08-09 12:53 ` Eli Zaretskii
2023-08-09 15:51 ` Thomas Fitzsimmons
2023-08-09 15:56 ` Mauro Aranda
2023-08-09 18:03 ` Mauro Aranda
2023-08-10 22:58 ` Mauro Aranda
2023-08-11 13:29 ` Thomas Fitzsimmons
2023-08-15 22:46 ` Mauro Aranda
2023-08-16 15:16 ` Thomas Fitzsimmons [this message]
2023-08-19 8:34 ` Eli Zaretskii
2023-08-21 12:23 ` Mattias Engdegård
2023-08-21 14:43 ` Mauro Aranda
2023-08-21 15:24 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3edk3qapb.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=63290@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).