From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Date: Wed, 13 Jul 2011 23:28:33 +0200 Message-ID: References: <87ljbyt7jg.fsf@jidanni.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1310594822 28215 80.91.229.12 (13 Jul 2011 22:07:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2011 22:07:02 +0000 (UTC) Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 14 00:06:57 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7a5-0003NW-5O for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jul 2011 00:06:57 +0200 Original-Received: from localhost ([::1]:45762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh7a3-0000Bp-Hi for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2011 18:06:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:35547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh7UV-0007Hq-As for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 18:01:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qh7UQ-0007WT-Il for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 18:01:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh7UQ-0007WF-7l for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 18:01:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qh7UO-0002eN-3h; Wed, 13 Jul 2011 18:01:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 22:01:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.13105944227333 (code B ref 6117); Wed, 13 Jul 2011 22:01:04 +0000 Original-Received: (at 6117) by debbugs.gnu.org; 13 Jul 2011 22:00:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7Te-0001u0-B6 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:00:22 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7TP-0001l6-Ij for 6117@debbugs.gnu.org; Wed, 13 Jul 2011 18:00:10 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh7TA-0005pw-1n; Wed, 13 Jul 2011 23:59:48 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 06 May 2010 09:17:35 -0400") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Tom Tom Club's _Close To The Bone_ X-Hashcash: 1:23:110713:jidanni@jidanni.org::9aut93aRXGDyy1jt:00000000000000000000000000000000000000000076Aq X-Hashcash: 1:23:110713:monnier@iro.umontreal.ca::hNJjguVAnIZdG6m2:00000000000000000000000000000000000004CEF X-Hashcash: 1:23:110713:6117@debbugs.gnu.org::owUsnGD0wN4QvoPY:000000000000000000000000000000000000000018l0c X-MailScanner-ID: 1Qh7TA-0005pw-1n MailScanner-NULL-Check: 1311199188.40464@gs+Jez6zy5Xedau1Fngvxw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 13 Jul 2011 18:01:04 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48928 Archived-At: Stefan Monnier writes: >> Please don't use the same colors for both "*" and "D" marked files, >> seen here: > >> (defface dired-marked >> '((t (:inherit font-lock-warning-face))) >> "Face used for marked files." >> :group 'dired-faces >> :version "22.1") >> (defvar dired-marked-face 'dired-marked >> "Face name used for marked files.") > >> (defface dired-flagged >> '((t (:inherit font-lock-warning-face))) >> "Face used for flagged files." >> :group 'dired-faces >> :version "22.1") >> (defvar dired-flagged-face 'dired-flagged >> "Face name used for flagged files.") > > Agreed. And while there, please fix the docstrings so they say more > clearly what's different about "flagged vs marked". I've fixed the doc string, but what colours should be used, then? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/