From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches Date: Wed, 19 Apr 2023 08:48:54 -0400 Message-ID: References: <874jpqalh7.fsf@fedora.home> <873557pn9h.fsf@fedora.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21188"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62721@debbugs.gnu.org, Filipp Gunbin To: Fabrice Bauzac-Stehly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 14:51:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pp7HJ-0005JT-Qy for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 14:51:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pp7H4-0004fm-Nb; Wed, 19 Apr 2023 08:51:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp7Gb-0004Qq-Bg for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 08:50:40 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pp7G7-0003Ab-31 for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 08:50:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pp7G6-00067D-Fj for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 08:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62721 X-GNU-PR-Package: emacs Original-Received: via spool by 62721-submit@debbugs.gnu.org id=B62721.168190854523439 (code B ref 62721); Wed, 19 Apr 2023 12:50:02 +0000 Original-Received: (at 62721) by debbugs.gnu.org; 19 Apr 2023 12:49:05 +0000 Original-Received: from localhost ([127.0.0.1]:33011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp7FB-00065y-05 for submit@debbugs.gnu.org; Wed, 19 Apr 2023 08:49:05 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]:45682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp7F8-00065T-Ld for 62721@debbugs.gnu.org; Wed, 19 Apr 2023 08:49:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jiGGUE69Nle2VZAb04edYp3JcoYj/4QEK1sSkf9tIbw=; b=R9TjsIkPAP5crCc2udYm2Ga8xK Rj1gj8vJaxHdrzMiMOKW+in1CUxH/Du483IUeXrdTcQgHie+s8emmzDH5QEqWC6zDJEz30Afbg62b OKRTGjrP0eeKzQ5csOxi+cO8etxuct2gtKzQSBI8FXvs+xlLU+fN4xkNq8F/XT4c6jB94UuIUGIVZ jd+t1Srl/hFQ6xWa3lj1prgxBdBLghV2hPjRTe+pN2jaE5IIFopOGxZn3hR3B4BSqvv6R+/Nx1O4+ aB9mSYVQ7mKbSBVQKgvUC5YElYtqVH+AHSn6BpKYEW7nzVxMQDrueJcMYGi30pWaYcwYOQX/vEK/G e76tEFLg==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pp7F1-000Nho-K0; Wed, 19 Apr 2023 08:48:56 -0400 In-Reply-To: (Filipp Gunbin's message of "Mon, 10 Apr 2023 22:36:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260268 Archived-At: Hi Fabrice, Filipp Gunbin writes: > On 10/04/2023 21:09 +0200, Fabrice Bauzac-Stehly wrote: > >> Hello, >> >> Sorry, I have not put sufficient information in my initial message. In >> my case, I'm using eudc-query-form, where I know I can add wildcards to >> the fields if I want. My complaint is about the fact that a wildcard is >> imposed on me in this case, with annoying consequences. Thanks to your >> message, I understand though that this automatic wildcard may be useful >> in other contexts where `eudc-ldap-format-query-as-rfc1558' is called. >> >> Customizing `eudc-ldap-no-wildcard-attributes' would work in the sense >> that I could disable the wildcards in all cases, but I suspect this >> solution is not ideal as it would also disable it in the case of >> eudc-expand-inline where (as I understand from your message) it would >> actually be useful. >> >> I think that in the case of eudc-query-form, no wildcard should ever be >> added. What do you think? Should we pass some parameter so that >> eudc-ldap-format-query-as-rfc1558 knows what to do? >> >> Thanks! > > To me, it's always useful to have wildcard. > > Would this simple advice help in your case? I tried it with mail, > replace it with your attributes. > > (defun my/eudc-process-form (orig &rest args) > (let ((eudc-ldap-no-wildcard-attributes > (cons 'mail eudc-ldap-no-wildcard-attributes))) > (apply orig args))) > > (advice-add 'eudc-process-form :around #'my/eudc-process-form) Did the advice that Filipp suggested work for you? Maybe we could add a checkbox to eudc-query-form whether to tack on a wildcard or not, defaulted to the value of eudc-ldap-no-wildcard-attributes. Thomas