From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Date: Fri, 11 Aug 2023 09:29:24 -0400 Message-ID: References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63290@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 11 15:30:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUSDe-000A7U-6c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Aug 2023 15:30:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUSDP-0002br-5w; Fri, 11 Aug 2023 09:30:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUSDK-0002bI-Ky for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 09:30:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUSDK-00074p-Cg for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUSDK-0007Lx-7M for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2023 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63290-submit@debbugs.gnu.org id=B63290.169176057428202 (code B ref 63290); Fri, 11 Aug 2023 13:30:02 +0000 Original-Received: (at 63290) by debbugs.gnu.org; 11 Aug 2023 13:29:34 +0000 Original-Received: from localhost ([127.0.0.1]:45174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUSCr-0007Kn-Ir for submit@debbugs.gnu.org; Fri, 11 Aug 2023 09:29:33 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]:50638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUSCp-0007Ka-FY for 63290@debbugs.gnu.org; Fri, 11 Aug 2023 09:29:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Nk7gx1Y+7N0RZF7oP3Y/bw+j+cBfUDX0toVC/ohGw+U=; b=KhnhrYqex7QUo0omweP9EDKzGI HUMbKtjJ27mRx32lm/Pqjg+J8wy0eatxwK0Hn32XtuN/GiAm4Ns9gxbOcr8zb/yZ932gS2exSaJIz hn//2eBpgY7PBAH1OvFx5iraLWJAy9gl8ioYMjcdg/kvGTuQvT97pkO7izy/xhjggQ79+qZOwd3oL 9IMqKiqQzge8KiM8rmhkvRjf/LWOImt9wjfP9ipSGWYYsPrZfjpkKa9TOM3JBqD5wUidvK3oV+co9 U9URpVAMJBvvlEjryEmeSjBfOURsqd/7x1GeZVTSfw/LwbrcfsqrEnwUPa2uxPDCJNp4poQa2vPQ0 Ql4J9P2A==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qUSCj-001LpF-09; Fri, 11 Aug 2023 09:29:25 -0400 In-Reply-To: <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> (Mauro Aranda's message of "Thu, 10 Aug 2023 19:58:24 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267212 Archived-At: Mauro Aranda writes: > Thomas Fitzsimmons writes:=20 >=20 >> Hi Mauro,=20 >>=20 >> Mauro Aranda writes:=20 >>=20 >>> I ended up adding a custom :default-get function for the list=20 >>> widget, to make it respect a nil value as the :value.=C2=A0 This=20 >>> should be backward compatible with other widgets, and should=20 >>> fix these "ghost" elements insertions. I also added a test for=20 >>> cus-edit-tests.=20 >>=20 >> Can you try this patch with:=20 >>=20 >> M-x package-install RET excorporate RET=20 >>=20 >> Then:=20 >>=20 >> M-x customize-variable RET excorporate-configuration RET=20 >>=20 >> then select "Value Menu" and 3, which is "EWS URL OAuth 2.0=20 >> settings (no autodiscovery)".=C2=A0 With your wis-edit.el patch=20 >> applied I still get empty values for:=20 >> =C2=A0=C2=A0=C2=A0 INS DEL Argument name:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Argument value:=20=20 >> and:=20 >> =C2=A0=C2=A0=C2=A0 INS DEL OAuth 2.0 setting name:=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 OAuth 2.0=20 >>setting =C2=A0=C2=A0 value:=20=20 >> and when I apply the setting the value contains:=C2=A0=C2=A0=20 >> (... (... (#1# . #1#))=C2=A0=C2=A0=C2=A0 (#1# . #1#))=20 >>=20 >> Maybe this is a more complicated case than the test case I=20 >> provided (which does now work for me with your patch)?=20 >=20 > I think this ammended patch fixes it.=C2=A0 Since we want=20 > widget-list-default-get to respect a nil :value property, the=20 > alist widget needs to be modified so that its default value is=20 > nil.=20 With the updated patch, when I select "EWS URL OAuth 2.0 settings=20 (no autodiscovery)", all the widgets are disabled. The blank=20 values are no longer added though. However, if I then set the=20 value, without configuring anything, excorporate-configuration=20 stays nil. So I don't think the patch is correct yet. Thomas