From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#21350: 25.0.50; Do not automatically include authorization header in HTTP redirects Date: Mon, 31 Aug 2015 22:33:05 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441074864 1185 80.91.229.3 (1 Sep 2015 02:34:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Sep 2015 02:34:24 +0000 (UTC) Cc: 21350@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 01 04:34:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZWbOl-0005xf-J6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2015 04:34:11 +0200 Original-Received: from localhost ([::1]:43585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWbOl-0001pK-2u for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Aug 2015 22:34:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWbOg-0001p4-F2 for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 22:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWbOc-00005c-DC for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 22:34:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWbOc-00005W-9g for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 22:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZWbOc-00021B-0L for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 22:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2015 02:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21350-submit@debbugs.gnu.org id=B21350.14410747917694 (code B ref 21350); Tue, 01 Sep 2015 02:34:01 +0000 Original-Received: (at 21350) by debbugs.gnu.org; 1 Sep 2015 02:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:44535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWbNm-000200-WC for submit@debbugs.gnu.org; Mon, 31 Aug 2015 22:33:11 -0400 Original-Received: from mail-io0-f177.google.com ([209.85.223.177]:35001) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWbNl-0001zs-1V for 21350@debbugs.gnu.org; Mon, 31 Aug 2015 22:33:09 -0400 Original-Received: by iog7 with SMTP id 7so56604246iog.2 for <21350@debbugs.gnu.org>; Mon, 31 Aug 2015 19:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=y2VnLVOab0+rsYOh7akWxWylhR8ZwiR26MYuiilfuuc=; b=WjoRokvsGye7omuO2HDDUWCze1jzeVZLQya+5OEo7Lqp2I1phqYUp0qFQb9zci0khk DbQgtegs8+hpvaGQGxpXV0QuSHhO49j5D+46vIyMmcYmTdUJL0G0j2gyx4USIZaHbjQG qHkfH9FB0p11IgmvmSnE/JJT273hjJ1Yxsc9Js0RfYtGG9dYu5j00SppXsXVeqzPPXjY pXAV+QTW2/+csQ3GLcHNXDD8blx3frYZ87zHzJA+3qdrpenRdiYN0Q8IbOzLvDTi/1Gv 8ryQiEOsSFKAxn0jINTKjQGsa7uJ1oGEbF/mxWQJ+hD2OH5xNcRsHXuANueQnCS4CQXl a0Cw== X-Gm-Message-State: ALoCoQnlKmc3efxZxS/Sz51ROAiFW17R/UmF4N5HwJEvx3lPdEWkMktcwGQAuAdJ6S/cHJPqphqM X-Received: by 10.107.155.4 with SMTP id d4mr7409672ioe.121.1441074788415; Mon, 31 Aug 2015 19:33:08 -0700 (PDT) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id i125sm14765520ioi.36.2015.08.31.19.33.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Aug 2015 19:33:06 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sat, 29 Aug 2015 11:21:35 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106030 Archived-At: Stefan Monnier writes: >> This patch is required for url-http-ntlm.el to handle redirects. I'd >> like someone more familiar with url-http.el to review it. > > I'm not sure if there is such a someone, to tell you the truth. I can > give you comments about Elisp style: OK, thanks. > + ;; Don't automatically include authorization header in redirect. > + ;; If needed it will be regenerated by the relevant auth scheme > + ;; when the new request happens. > + (setq url-http-extra-headers > + (let (result) > + (dolist (header url-http-extra-headers) > + (if (not (equal (car header) "Authorization")) > + (push header result))) > + (nreverse result))) > > IIUC this is like: > > (let ((a (assoc "Authorization" url-http-extra-headers))) > (if a (setq url-http-extra-headers (delq a url-http-extra-headers)))) > > Tho maybe it should be `remq' rather than `delq'. I was trying to remove all occurrences of "Authorization", just in case, since that's what url-http-ntlm did. I looked at remq and delq. delq looks like it would be faster. I'm not sure why I would use remq since I'm overwriting url-http-extra-headers anyway. url-http-ntlm did this: (defun url-http-ntlm-rmssoc (key alist) (remove* key alist :key 'car :test 'equal)) but should I avoid using cl-lib in this context? Another consideration is that I want to be able to backport this change (as an ELPA-installed patch) all the way back to Emacs 24.1, so maybe that's another reason not to use cl-lib. Thomas