From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Date: Sun, 22 Jul 2018 16:31:55 +0200 Message-ID: References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <83zhyjweao.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532269866 1871 195.159.176.226 (22 Jul 2018 14:31:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2018 14:31:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 22 16:31:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFO1-0000Mm-Km for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2018 16:31:01 +0200 Original-Received: from localhost ([::1]:56226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhFQ8-00024L-MW for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2018 10:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhFQ2-00024B-D5 for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhFPz-0000QB-6u for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:33:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhFPz-0000Q5-20 for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fhFPy-0000tQ-GN for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jul 2018 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31901-submit@debbugs.gnu.org id=B31901.15322699223354 (code B ref 31901); Sun, 22 Jul 2018 14:33:02 +0000 Original-Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 14:32:02 +0000 Original-Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFP0-0000rz-0T for submit@debbugs.gnu.org; Sun, 22 Jul 2018 10:32:02 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:58673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFOw-0000ri-Dh for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:32:00 -0400 Original-Received: from cm-84.212.221.165.getinternet.no ([84.212.221.165] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fhFOt-0006Cl-8O; Sun, 22 Jul 2018 16:31:57 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEVz/2J12VZ0/2Fz/2Nw /2Bz915QiTJv/2NbtkImMhVooORwAAACG0lEQVQ4jXWTMW/bMBCFBbTofqrpqCNpuEi3VKxjeKsQ ukRGuVbdVYshbVUll101hKD/gBH/2xwp0VKQ5IEQTH/37pEHKVBKCCGVkxRWjVK4ggoakQD+e5hI C6SQWHalghQaksB6q6orUU0gJWupqvVHCypIYApQbUWS/4IpAdzlyyBJAEGe7KawlZBMYELyKexU cGiabbKDRFXv8QzYTQB8PWA4xtpADLdnUU0juhM64De9pAeyiozB5XVxND/2TudOpwuQDuijB6IH jbDAaF32xE3IO0xhdNED6QCeyLUqdHHyoGuFt0Cg0bAvnwGUbWX0fv/Jh9+p2l0QQWGwXe+wtbV3 OL0A/94CnUOX++Hm3N2jd5SDY8lHIxkDXo+H+Bw03QVHhrOqlzUPpJLyXrtehe7OVaNchrq3o3r4 n0XEjZ5bIeB3K6x/WENUkPVxAPhAR1614rc5GFN6UC+X724f84z8uYkMX5BF2YOm5vzDY2t+8joz nC8iD77hY3UybZYC6BYi48EN5/HqjGM32riX6NiDv/i4PdvXqQfe8d228o52BLhzOKB7MLuAL75V CwNgMz77fC7MqFXvmMXsGkud8GuCqO0yWMy8ZnHc7WJmwSBscfnJAkYZJZuQpBsKQEMGtENBiqPA lUNImQUhnTNGIQxojoWYSS8OwBoLCMznMAQBpWnISDgO93IpwZxt3gAZghcMQbZ5nTwB3/mBpZ4W IzEAAAAASUVORK5CYII= In-Reply-To: <83zhyjweao.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Jul 2018 17:11:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148811 Archived-At: Eli Zaretskii writes: >> I've fixed this on master, because I'm not 100% sure that my fix is >> completely correct. Should we perhaps also call a sentinel in the async >> error case? > > But we didn't call the sentinel before, did we? I don't think we did, but I'm not completely sure. I tried following the pre-Emacs 26 code flow, and I didn't see a call, but I may be mistaken. >> But we should, in any case, perhaps cherry-pick this fix into Emacs >> 26.2. > > It looks like the only visible change in behavior is that we now store > the error in the process object, is that right? Yup. That is, it should be unless I messed something up in the refactoring of report_file_errno. :-) > If so, I think we want this on emacs-26, yes. Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no