From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping Date: Tue, 25 Jun 2019 16:46:47 +0200 Message-ID: References: <83bna0di5k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77327"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 22114@debbugs.gnu.org, Vasilij Schneidermann To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 16:48:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfmk7-000JwY-P0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 16:48:19 +0200 Original-Received: from localhost ([::1]:32782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfmk6-0005NW-Bw for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 10:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50444) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfmj1-0005LC-Mv for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:47:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfmix-0007uM-PN for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:47:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47871) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfmir-0007p1-Tf for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfmir-0004sa-M8 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22114-submit@debbugs.gnu.org id=B22114.156147401518437 (code B ref 22114); Tue, 25 Jun 2019 14:47:01 +0000 Original-Received: (at 22114) by debbugs.gnu.org; 25 Jun 2019 14:46:55 +0000 Original-Received: from localhost ([127.0.0.1]:33182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfmik-0004n6-Lk for submit@debbugs.gnu.org; Tue, 25 Jun 2019 10:46:54 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfmii-0004kQ-0D for 22114@debbugs.gnu.org; Tue, 25 Jun 2019 10:46:53 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfmid-00014F-VL; Tue, 25 Jun 2019 16:46:50 +0200 In-Reply-To: <83bna0di5k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Dec 2015 18:22:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161374 Archived-At: Eli Zaretskii writes: > I don't really understand why profiler.el insists on having the > profiler running for providing the profile. The much simpler patch > below makes it possible for me to invoke profiler-report whether a > profile is running or not. Does it work for you? If not, can you > tell what I missed? > > --- lisp/profiler.el~4 2015-11-11 07:57:32.000000000 +0200 > +++ lisp/profiler.el 2015-12-08 17:54:27.380084700 +0200 > @@ -216,19 +216,17 @@ > > (defun profiler-cpu-profile () > "Return CPU profile." > - (when (profiler-running-p 'cpu) > - (profiler-make-profile > - :type 'cpu > - :timestamp (current-time) > - :log (profiler-cpu-log)))) > + (profiler-make-profile > + :type 'cpu > + :timestamp (current-time) > + :log (profiler-cpu-log))) [etc] The discussion then turned to other things (like getting in-progress reports), but this seems like the simplest solution that solves the originally stated problem. But it wasn't applied -- I can do that now, if that's convenient... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no