From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#35969: 26.2, Excorporate Date: Wed, 19 Jun 2019 00:26:04 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200269"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Andreas Schwab , 35969@debbugs.gnu.org To: "tenspd137 ." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 19 06:28:48 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdSDI-000pzu-8B for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2019 06:28:48 +0200 Original-Received: from localhost ([::1]:35035 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdSDH-0008Q4-6q for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2019 00:28:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55920) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdSBc-00078z-Qu for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 00:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdSBb-0004oK-2U for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 00:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60545) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdSBa-0004nj-3m for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 00:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hdSBZ-0003rs-Ts for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 00:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2019 04:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35969 X-GNU-PR-Package: emacs Original-Received: via spool by 35969-submit@debbugs.gnu.org id=B35969.156091837614765 (code B ref 35969); Wed, 19 Jun 2019 04:27:01 +0000 Original-Received: (at 35969) by debbugs.gnu.org; 19 Jun 2019 04:26:16 +0000 Original-Received: from localhost ([127.0.0.1]:45856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdSAp-0003q5-N9 for submit@debbugs.gnu.org; Wed, 19 Jun 2019 00:26:16 -0400 Original-Received: from mail-io1-f65.google.com ([209.85.166.65]:44210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdSAm-0003pk-Vi for 35969@debbugs.gnu.org; Wed, 19 Jun 2019 00:26:14 -0400 Original-Received: by mail-io1-f65.google.com with SMTP id s7so34978875iob.11 for <35969@debbugs.gnu.org>; Tue, 18 Jun 2019 21:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AB+vQeWxknYMScNtOnjYQ6eOKd6iJbnHngUN2gTp+Ag=; b=HEYIy0keTI6teamfQUJis9pBpK82bAvR/Dl8XiEnX1ygYxDsin3Q9OdlxR7AaIaOdM OTeAxonzNakIt8CeeIMf4iPNSpeH1/f2wprUUGpO92mxHAcQV0DplpNVqEWtYtzRQJAS axr1L7V0REe5INz2lIcjPXPwOhMPnoM193DKwTgizyK6JSlxfEkamUnaLyHIIsL+3+zQ +47/T5zZ643uAG2xTrAfGkgzP6Uj9Vw4xILG/Fdi1i6m2s6aRxM9HS64udegz9nazUVn mBioDv9orksdBKf5WhvjYWzfhhahJ6wOliwTLrUIP1hNBwdO4XfhoK8JaTM1QKr/vFr2 Ywsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AB+vQeWxknYMScNtOnjYQ6eOKd6iJbnHngUN2gTp+Ag=; b=Vzp56+FuQd4SXUezPiGhzV9h37DOzWgsCVnp/VSAc7v5oD8szMHrKexnQV+zbEinrl vA5ULuwx79D3yKYEUAjcFRf2a72R9XqTDkXjE/5g+q3IRxazgaxm9mjtgKGJMdahPbf+ uJIhj8fSmlZa7TD7Bdkyu7qHnv/7OUCGfMfqlRfkz/PWbm7JIjW15iBCqw739/wf7+8B ANCSWGTPznblqHOZsml/IDPnj45K0x2NH2BBu88vJQRo4U97Q74yp3Nbklv6JYL6L7nZ L6WZlfHgBZ/ngsOTIkuQRfDNyxvRIiRptIjEm4Nvo9zgHY2YoIJPJ0ccP1flVA0R1TXS BXbg== X-Gm-Message-State: APjAAAUbT+3zQzgaJVZifAve+CdfifVDND53j2/+FbmiNdBEZ29douVt cgKf1mxiMHUtuchzUd/EIk0/v/2+EE0= X-Google-Smtp-Source: APXvYqw9Giv7V0mdcfm/N2XJFRVjbhwn6tFTacVfd6dgfFSjFeph1lUNncKObTiBCk4ycSl/53c5Pw== X-Received: by 2002:a02:7b2d:: with SMTP id q45mr91373389jac.127.1560918367082; Tue, 18 Jun 2019 21:26:07 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id h19sm13829313iol.65.2019.06.18.21.26.05 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jun 2019 21:26:06 -0700 (PDT) In-Reply-To: (tenspd's message of "Tue, 18 Jun 2019 10:34:05 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160822 Archived-At: Hi, "tenspd137 ." writes: > So - I am not sure if I did it correctly, but I copied this function > with Andreas' changes into a file: > > (defun url-https-proxy-after-change-function (_st _nd _length) > (let* ((process-buffer (current-buffer)) > (proc (get-buffer-process process-buffer))) > (goto-char (point-min)) > (when (re-search-forward "^\r?\n" nil t) > (backward-char 1) > ;; Saw the end of the headers > (setq url-http-end-of-headers (set-marker (make-marker) (point))) > (url-http-parse-response) > (cond > ((null url-http-response-status) > ;; We got back a headerless malformed response from the > ;; server. > (url-http-activate-callback) > (error "Malformed response from proxy, fail!")) > ((= url-http-response-status 200) > (if (gnutls-available-p) > (condition-case e > (let ((tls-connection (gnutls-negotiate > :process proc > :hostname (url-host url-current-object) > :verify-error nil))) > ;; check certificate validity > (setq tls-connection > (nsm-verify-connection tls-connection > (url-host url-current-object) > (url-port url-current-object))) > (with-current-buffer process-buffer (erase-buffer)) > (set-process-buffer tls-connection process-buffer) > (setq url-http-after-change-function > 'url-http-wait-for-headers-change-function) > (set-process-filter tls-connection 'url-http-generic-filter) > (process-send-string tls-connection > ;; Use the non-proxy form of the request > (let (url-http-proxy) > (url-http-create-request)))) > (gnutls-error > (url-http-activate-callback) > (error "gnutls-error: %s" e)) > (error > (url-http-activate-callback) > (error "error: %s" e))) > (error "error: gnutls support needed!"))) > (t > (url-http-debug "error response: %d" url-http-response-status) > (url-http-activate-callback)))))) > > and then loaded it before running excorporate. After that, I did M-x > excorporate, and the minibuffer returns: error in process filter: > Server response is not an XML document In this scenario, if you immediately (without restarting Emacs/reloading anything) re-run M-x excorporate does it still fail? I just want to make sure that's not a transient failure. If it does fail the second time, can you post the HTTP response from the server? > When I do the similar test by loading the url-http-create-request with > Thomas's changes, I can get a connection and grab my schedule > through the proxy. OK. > Let me know if I need to try something different. Are you in a position to build Emacs master tip and retry the experiment without patching anything? Thanks, Thomas > On Mon, Jun 17, 2019 at 4:08 PM Thomas Fitzsimmons wrote: >> >> Hi, >> >> Good to hear that the patch I posted worked! >> >> Yes, that's the patch that Andreas's commit >> 84613dae5c34ea742dd9a3e56f5acb55f604b483 applied. From what I can tell, >> you will not have that in Emacs 26.2. >> >> Can you try reverting my patch and applying Andreas's patch, and see if >> Excorporate still works through the proxy? >> >> Thanks, >> Thomas >> >> "tenspd137 ." writes: >> >> > The patch Thomas seems to work from behind the proxy. My current >> > emacs version is 26.2, so I would think it would include the commit >> > Andreas is talking about.... I went and looked it up - is this the >> > correct commit? >> > >> > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el >> > index 53798f7..817c5ce 100644 >> > --- a/lisp/url/url-http.el >> > +++ b/lisp/url/url-http.el >> > @@ -1412,7 +1412,9 @@ The return value of this function is the >> > retrieval buffer." >> > 'url-http-wait-for-headers-change-function) >> > (set-process-filter tls-connection 'url-http-generic-filter) >> > (process-send-string tls-connection >> > - (url-http-create-request))) >> > + ;; Use the non-proxy form of the request >> > + (let (url-http-proxy) >> > + (url-http-create-request)))) >> > (gnutls-error >> > (url-http-activate-callback) >> > (error "gnutls-error: %s" e)) >> > >> > Thanks! >> > >> > -C >> > >> > >> > On Sat, Jun 15, 2019 at 1:41 AM Andreas Schwab wrote: >> >> >> >> On Jun 14 2019, Thomas Fitzsimmons wrote: >> >> >> >> > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el >> >> > index 00803a103a..723d111d58 100644 >> >> > --- a/lisp/url/url-http.el >> >> > +++ b/lisp/url/url-http.el >> >> > @@ -329,7 +329,10 @@ url-http-create-request >> >> > ;; The request >> >> > (or url-http-method "GET") " " >> >> > (url-http--encode-string >> >> > - (if using-proxy (url-recreate-url url-http-target-url) real-fname)) >> >> > + (if (and using-proxy >> >> > + (not (equal "https" (url-type url-http-target-url)))) >> >> > + (url-recreate-url url-http-target-url) >> >> > + real-fname)) >> >> >> >> That should already be handled by commit 84613dae5c. >> >> >> >> Andreas. >> >> >> >> -- >> >> Andreas Schwab, schwab@linux-m68k.org >> >> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 >> >> "And now for something completely different."