From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4310: Flymake standardizing(slightly) patch Date: Thu, 27 Jun 2019 19:52:08 +0200 Message-ID: References: <4A9E01DC.3030903@gmail.com> <87twktqqpl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="167191"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 4310@debbugs.gnu.org To: Jimmy Yuen Ho Wong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 19:53:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYaF-000hIX-64 for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 19:53:19 +0200 Original-Received: from localhost ([::1]:53360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgYaE-0001Md-8v for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 13:53:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39606) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgYZz-0001K9-HR for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:53:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgYZy-00008e-CS for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54231) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgYZy-00008M-8w for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgYZy-0004Sb-3j for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4310 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 4310-submit@debbugs.gnu.org id=B4310.156165793617085 (code B ref 4310); Thu, 27 Jun 2019 17:53:02 +0000 Original-Received: (at 4310) by debbugs.gnu.org; 27 Jun 2019 17:52:16 +0000 Original-Received: from localhost ([127.0.0.1]:39542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYZD-0004RT-TD for submit@debbugs.gnu.org; Thu, 27 Jun 2019 13:52:16 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:46252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYZC-0004RK-AT for 4310@debbugs.gnu.org; Thu, 27 Jun 2019 13:52:14 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYZ7-0008IY-4t; Thu, 27 Jun 2019 19:52:13 +0200 In-Reply-To: <87twktqqpl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 28 Feb 2016 17:44:22 +1100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161629 Archived-At: Lars Ingebrigtsen writes: >> +(defvar flymake-prefix-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map "s" 'flymake-start-syntax-check) >> + (define-key map "n" 'flymake-goto-next-error) >> + (define-key map "p" 'flymake-goto-prev-error) >> + (define-key map "m" 'flymake-display-err-menu-for-current-line) >> + map)) >> + >> +(defvar flymake-mode-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map "\C-c;" flymake-prefix-map) >> + map) >> + "The keymap provides the default flymake-mode bindings.") >> + >> +(defvar flymake-mode-hook nil >> + "Mode hook for `flymake-mode`. This hook is run __before__ >> +syntax check happens, but after all the initialization is done.") > > As Glenn said, the hook isn't needed, but I think the minor mode map > might make sense. > > I've never used flymake, though, so I can't really say. Anybody? Didn't seem to be much enthusiasm for this over the years, so it seems unlikely that progress will be made, and I'm closing this bug report. Please reopen if somebody wants to add that keymap... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no