unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <steve@ims.uni-stuttgart.de>
Subject: quick fix to todo-mode patch + followup question
Date: 03 Jun 2002 12:06:58 +0200	[thread overview]
Message-ID: <m37klgekvx.fsf@steve.ims.uni-stuttgart.de> (raw)
In-Reply-To: <m3sn4bri30.fsf@steve.ims.uni-stuttgart.de>

I just discovered a silly mistake I made in the todo-mode patch I
posted here last Wednesday: I bound `todo-kill-buffer' to `q' in
todo-edit-mode, which prevents `q' from being a self-inserting key
when editing a multiline TODO item.  Please apply the below patch to
my previous patch.

I made this diff against my previous patch, which was itself against
the current CVS todo-mode, because it is small and that patch is
rather big.  If I should discover further mistakes in my patch code, I
would like to follow this same procedure.  Is this appropriate?  The
alternative, essentially resubmitting the large patch augmented with a
small change, seems like a waste of bandwidth.  This consideration
also leads me to ask the following question: If I implement further
extensions to todo-mode, would it also be acceptable to submit them as
patches to my large patch, i.e., basically to treat my patch as the
status quo of todo-mode?  This may seem presumptuous, since my patch
hasn't been applied and may never be.  However, the new code in the
patch is almost as long as the todo-mode code contained in Emacs, so
again, diffing against that every time seems like massive redundancy.
A possible alternative would be to rename the file and submit it to
gnu-emacs-sources, but I don't think this is appropriate, since after
all half the code still comes from Oliver Seidel, not me: I haven't
rewritten todo-mode, I've extended it.  So to sum up, my general
question is: what's the appropriate way to submit incremental fixes or
extensions to a not-yet-applied large patch to an Emacs package (one
that doubles the code base of the package)?

--Steve Berman

Here are the todo-mode ChangeLog entry and diff against my patch:

2002-06-03  Stephen Berman  <steve@ims.uni-stuttgart.de>

	* todo-mode-srb.el (todo-edit-mode):
	Change key binding of todo-kill-buffer from `q' to
	`C-c C-c', so that `q' can be self-inserted in the editing buffer.
	(todo-edit-multiline): Change message displayed upon entering editing
	buffer to reflect corrected key binding of todo-kill-buffer.

*** todo-mode.el~	Mon Jun  3 11:09:49 2002 (patched version 1.50)
--- todo-mode.el	Mon Jun  3 11:09:49 2002
***************
*** 861,867 ****
  	 (make-indirect-buffer
   	  (file-name-nondirectory todo-file-do) buffer-name))
  	(todo-edit-mode)
! 	(message "To finish editing and return to TODO item list, type q.")
  	(widen) ; in case the item is filed
  	(goto-char here)
  	;; This bit of code insures that, if the last unfiled or filed item
--- 867,873 ----
  	 (make-indirect-buffer
   	  (file-name-nondirectory todo-file-do) buffer-name))
  	(todo-edit-mode)
! 	(message "To finish editing and return to TODO item list, type C-c C-c.")
  	(widen) ; in case the item is filed
  	(goto-char here)
  	;; This bit of code insures that, if the last unfiled or filed item
***************
*** 1869,1875 ****
    "Major mode for editing items in the TODO list.
  
  \\{todo-edit-mode-map}"
!   (local-set-key (kbd "q") 'todo-kill-buffer)
    (add-hook 'todo-edit-mode-hook 'turn-on-auto-fill))
  
  (defun todo-categories-mode ()
--- 1875,1881 ----
    "Major mode for editing items in the TODO list.
  
  \\{todo-edit-mode-map}"
!   (local-set-key (kbd "C-c C-c") 'todo-kill-buffer)
    (add-hook 'todo-edit-mode-hook 'turn-on-auto-fill))
  
  (defun todo-categories-mode ()

      reply	other threads:[~2002-06-03 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-28 23:03 [PATCH] todo-mode extensions and bug fixes Stephen Berman
2002-06-03 10:06 ` Stephen Berman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37klgekvx.fsf@steve.ims.uni-stuttgart.de \
    --to=steve@ims.uni-stuttgart.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).