From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#19092: 25.0.50; [PATCH] ispell-message spell checks marked parts of messages Date: Tue, 25 Jun 2019 23:10:19 +0200 Message-ID: References: <87oas4bwwe.fsf@loki.home> <83r3x0a4id.fsf@gnu.org> <8761ecjne8.fsf@loki.home> <87r3g3prl4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142792"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 19092@debbugs.gnu.org To: Matthew Leach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 23:11:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfsj0-000b1N-2f for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 23:11:34 +0200 Original-Received: from localhost ([::1]:35268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfsiz-0004sB-4b for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 17:11:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35582) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfsia-0004rs-4H for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 17:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfsiY-0005hq-Rk for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 17:11:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfsiT-0005am-SZ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 17:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfsiT-0005Rf-JV for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 17:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 21:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19092-submit@debbugs.gnu.org id=B19092.156149702920875 (code B ref 19092); Tue, 25 Jun 2019 21:11:01 +0000 Original-Received: (at 19092) by debbugs.gnu.org; 25 Jun 2019 21:10:29 +0000 Original-Received: from localhost ([127.0.0.1]:33671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfshw-0005Qc-O1 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 17:10:29 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfshu-0005QR-05 for 19092@debbugs.gnu.org; Tue, 25 Jun 2019 17:10:26 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfshn-0004SY-Jz; Tue, 25 Jun 2019 23:10:23 +0200 In-Reply-To: <87r3g3prl4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 23 Feb 2016 22:57:11 +1100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161427 Archived-At: Lars Ingebrigtsen writes: > Matthew Leach writes: > >>> This changes behavior, so I think we should have a defcustom that >>> could be used to get the old behavior back. (And the NEWS entry >>> should describe that.) >> >> Ah, yes sorry about that. The revised patch fixes that. > > The patch no longer applies, so I've tried to fit it in. However, the > patch is using variables defined in message.el. Does it make sense to > have ispell.el require 'message? That seems rather odd... > > So I'm not sure this should go into Emacs in its present form... I think there should instead be a way for modes to tell ispell what parts of the buffer should (perhaps) not be spellcheked, and this patch approaches this from the opposite side, so I don't think it's the right solution. Closing the bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no