unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17630: 24.3.91; gv expander for a few places are incorrect
@ 2014-05-29 11:36 Leo Liu
  2014-05-29 13:18 ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Leo Liu @ 2014-05-29 11:36 UTC (permalink / raw)
  To: 17630


Hi Stefan,

These are incorrect:

(gv-define-simple-setter window-buffer set-window-buffer)
(gv-define-simple-setter window-display-table set-window-display-table 'fix)
(gv-define-simple-setter window-dedicated-p set-window-dedicated-p)
(gv-define-simple-setter window-hscroll set-window-hscroll)
(gv-define-simple-setter window-point set-window-point)
(gv-define-simple-setter window-start set-window-start)

The getter allows optional WINDOW arg but the setter requires WINDOW
arg. For example:

  (setf (window-buffer) (get-buffer "abc")) expands incorrectly to
  (set-window-buffer (get-buffer "abc"))

They should probably all be re-defined using gv-define-setter.

Leo





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-05-31 15:47 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-29 11:36 bug#17630: 24.3.91; gv expander for a few places are incorrect Leo Liu
2014-05-29 13:18 ` Stefan Monnier
2014-05-30  3:46   ` Leo Liu
2014-05-30 16:20     ` Stefan Monnier
2014-05-31  3:04       ` Leo Liu
2014-05-31 14:32         ` Stefan Monnier
2014-05-31 14:37         ` Stefan Monnier
2014-05-31 15:47           ` Leo Liu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).