From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Chris Zheng <chriszheng99@gmail.com>
Cc: 19231@debbugs.gnu.org
Subject: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64
Date: Mon, 01 Dec 2014 18:46:48 +0100 [thread overview]
Message-ID: <m361dv5kl3.fsf@stories.gnus.org> (raw)
In-Reply-To: <20141201.031748.1767411492928916984.chriszheng99@gmail.com> (Chris Zheng's message of "Mon, 01 Dec 2014 03:17:48 +0800")
Chris Zheng <chriszheng99@gmail.com> writes:
> * src/gnutls.c: In MinGW-w64, `gnutls_sign_algorithm_get_name' is
> defined as a macro to `gnutls_sign_get_name', so use
> `gnutls_sign_get_name' directly.
> (init_gnutls_functions): Load missing `gnutls_server_name_set'.
> (init_gnutls_functions): Use `gnutls_sign_get_name'.
> (gnutls_certificate_details): Use `fn_gnutls_sign_get_name'.
[...]
> +/* Use `gnutls_sign_get_name' instead of
> + `gnutls_sign_algorithm_get_name' for MinGW-w64. */
> +#if defined(MINGW_W64) && defined(gnutls_sign_algorithm_get_name)
> + const char *name = fn_gnutls_sign_get_name (err);
> +#else
> const char *name = fn_gnutls_sign_algorithm_get_name (err);
> +#endif
Instead of adding these ifdefs, perhaps we could just call
fn_gnutls_sign_get_name on all platforms? Or does that function not
exist on non-MingGW platforms?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2014-12-01 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 19:17 bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 Chris Zheng
2014-12-01 17:46 ` Lars Magne Ingebrigtsen [this message]
2014-12-02 13:03 ` Chris Zheng
2014-12-02 16:37 ` Lars Magne Ingebrigtsen
2014-12-03 4:37 ` Chris Zheng
2014-12-03 14:40 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m361dv5kl3.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=19231@debbugs.gnu.org \
--cc=chriszheng99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).