From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Fri, 08 Jun 2018 10:18:18 -0400 Message-ID: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528468393 32120 195.159.176.226 (8 Jun 2018 14:33:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Jun 2018 14:33:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Alexandru Harsanyi , 31742@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 08 16:33:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIRw-0008Fo-B4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 16:33:08 +0200 Original-Received: from localhost ([::1]:36166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRIU3-0002TB-G8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 10:35:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRIEP-0005IS-0q for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:19:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRIEJ-0002sc-2h for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:19:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60051) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRIEI-0002sO-Rc for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRIEI-0005wM-FO for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jun 2018 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31742-submit@debbugs.gnu.org id=B31742.152846750822758 (code B ref 31742); Fri, 08 Jun 2018 14:19:02 +0000 Original-Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 14:18:28 +0000 Original-Received: from localhost ([127.0.0.1]:39715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIDk-0005v0-CM for submit@debbugs.gnu.org; Fri, 08 Jun 2018 10:18:28 -0400 Original-Received: from mail-io0-f194.google.com ([209.85.223.194]:38526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIDi-0005uf-62 for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 10:18:27 -0400 Original-Received: by mail-io0-f194.google.com with SMTP id l19-v6so16078923ioj.5 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 07:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+Z1RUEijAjEhIst77KfTEPJThaNV6NTDpcEkVKIJUdU=; b=iQZdHv0Ni32gfmooiAeuQPPHWORLUkgtfYmFiuyiQmDi62EuW7i7dq8NiX2I9n1tJc GsJAAoVrC6IKwSYS30RxXfzeemIQua1J/1p2sSJ0DjRqDGxNlcp1jNYZj1vIl1JGqveI CqarptRg+8oTgLZ4YdlYj5xqR84/CHEEK9EagRbFRp5DwwRLpd1qf5GvJq87jlQtf9Bd IKvHKXDmVMjuk2yBatPUzLcL8MTfNVCXVKmUgs/RR5ylFHK8K7L2Y+ax2tkVglugYg+U 3uYs0F9LjPwFfJB91hQLeL8QwU1WLv8qvslQbwuYtgvSVYkKkuB7G8davkfKy42bv0S1 Y7gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+Z1RUEijAjEhIst77KfTEPJThaNV6NTDpcEkVKIJUdU=; b=Dv60G5uxDNf3nO1y/AEK4Ef4s4PU3I8182aHDF+nLI9mCBjTyp2D/E57fCPXZVR3PF c9cyk0vA62/4tPg3klTtf+KyuAiPYPuIM9533m4NRKB/SxfWa7DwjwITweGcn5K05ggE lyGhCobyiFeyh4bB3o8gbW6Ia+O2ClaoErFYQl3F2fYpCHgiuYa0FKS7iXtOkbCER+Ti 0s0mUN2N57yH356tPtmvNaBy7NmUEFfiQxhn4bX5ZR4LgwC5GUToqDFR5dlOWK+oN+4q pMK3B14QzDaD/Nq5CHqQWlqhgfAjkCFRT1oRyF5A/7kpwvVbAHfXjZZVTgUhDT36logO AZPQ== X-Gm-Message-State: APt69E2hKdiOZG2dhihJwAt/Cx9djZfmlm3cfEkWMlYTM0UH3xTIPreq NWWv3tSK4i6UfWw2Jrv9D+qkmw== X-Google-Smtp-Source: ADUXVKIsBWyxDL+ahpde/1WHQ0E4flF6Lxcp7Avpz9fGM3pSCkVgVDwONaagbzPbPVc2XyaUDE2tcA== X-Received: by 2002:a6b:5d0f:: with SMTP id r15-v6mr5601902iob.178.1528467500684; Fri, 08 Jun 2018 07:18:20 -0700 (PDT) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id u10-v6sm7759239iof.78.2018.06.08.07.18.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 07:18:19 -0700 (PDT) In-Reply-To: <87vaat1ndq.fsf@gmail.com> (Noam Postavsky's message of "Fri, 08 Jun 2018 08:19:45 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147172 Archived-At: (CCing Alex Harsanyi.) Noam Postavsky writes: > Thomas Fitzsimmons writes: > >> Noam Postavsky writes: >> >>> Thomas Fitzsimmons writes: >>> >>>> (defun soap-resolve-references (element wsdl) >>> >>>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >>> >>> Ah, then it should work to replace the (aref element 0) with (type-of >>> element) as long as cl-old-struct-compat-mode is enabled. >> >> Yes, I retested with that change and it does work. I guess I should >> submit a patch to change all those occurrences in soap-client. > > I just noticed soap-client is also an ELPA package; then there is the > additional complication that type-of will give the wrong answer in Emacs > versions 25 and older. So you would need something like > > (let ((type (type-of element))) > (if (eq type 'vector) > (aref element 0) ; For Emacs 25 and earlier. > type)) OK, I had that on my list to investigate before patching soap-client, the compatibility range of type-of, but you've done it for me, thanks. A soap-type-of compatibility function probably makes sense to replace the (aref ... 0) occurrences in soap-client and soap-inspect. >> I'm hoping cl-old-struct-compat-mode will continue to be enabled by >> default for a long time. > > I was going to say, it's currently not enabled by default, but it looks > like it gets enabled automagically when you load code from the old > cl-defstruct: > > (defun cl-struct-define (name docstring parent type named slots children-sym > tag print) > (unless type > ;; Legacy defstruct, using tagged vectors. Enable backward compatibility. > (cl-old-struct-compat-mode 1)) Ah, great, so that logic can stay in Emacs indefinitely without negatively affecting sessions that don't load old byte-code. Thomas