From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 22457@debbugs.gnu.org
Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes
Date: Wed, 26 Jun 2019 01:12:25 +0200 [thread overview]
Message-ID: <m35zotuuna.fsf@gnus.org> (raw)
In-Reply-To: <87ftnxmfoo.fsf@web.de> (Michael Heerdegen's message of "Wed, 26 Jun 2019 01:02:47 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Yes, I think I understand. My problem is that "[...] not how many files
> are marked in total" sounds like as if marked files that were not even
> touched by the command (that are not matched by the predicate) were
> previously included. You mean it relative to the files matched, right?
Well... this is the patch:
- (if ,predicate
- (progn
- (delete-char 1)
- (insert dired-marker-char)
- (setq count (1+ count))))
+ (when ,predicate
+ (unless (looking-at-p (char-to-string dired-marker-char))
+ (delete-char 1)
+ (insert dired-marker-char)
+ (setq count (1+ count))))
So if the predicate matches, if there was a mark, it would delete the
mark, and then add it back, and then count it.
But you're right, files where the predicate doesn't say non-nil are not
counted, so it doesn't report the total number of marked files...
> Oh, btw, this patch line
>
> (looking-at-p (char-to-string dired-marker-char))
>
> is not good if dired-marker-char is a regexp special like . or ?, I
> guess (regexp-quote missing)?
Indeed. I'll fix it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-06-25 23:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 18:05 bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Drew Adams
2019-06-25 14:42 ` Lars Ingebrigtsen
2019-06-25 15:33 ` Drew Adams
2019-06-25 15:44 ` Lars Ingebrigtsen
2019-06-25 22:47 ` Michael Heerdegen
2019-06-25 22:53 ` Lars Ingebrigtsen
2019-06-25 23:02 ` Michael Heerdegen
2019-06-25 23:12 ` Lars Ingebrigtsen [this message]
2019-06-25 23:26 ` Drew Adams
2019-06-25 23:30 ` Michael Heerdegen
2019-06-26 0:00 ` Drew Adams
2019-06-26 8:50 ` Andreas Schwab
2019-06-26 13:32 ` Drew Adams
2019-06-25 23:17 ` Drew Adams
2019-06-25 23:28 ` Michael Heerdegen
2019-06-25 15:46 ` Lars Ingebrigtsen
2019-06-25 16:06 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m35zotuuna.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22457@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).