From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Wed, 16 Nov 2022 15:54:11 -0500 Message-ID: References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1174"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 16 21:55:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovPRK-000Aa0-0v for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Nov 2022 21:55:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovPR3-0007wl-4a; Wed, 16 Nov 2022 15:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovPR1-0007wR-4w for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 15:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovPR0-0007Ft-Sr for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 15:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovPR0-0001dS-Ew for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 15:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.16686320636235 (code B ref 59314); Wed, 16 Nov 2022 20:55:02 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 16 Nov 2022 20:54:23 +0000 Original-Received: from localhost ([127.0.0.1]:58291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovPQM-0001cU-Iv for submit@debbugs.gnu.org; Wed, 16 Nov 2022 15:54:22 -0500 Original-Received: from mail.fitzsim.org ([69.165.165.189]:39006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovPQI-0001cF-NR for 59314@debbugs.gnu.org; Wed, 16 Nov 2022 15:54:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d3T1JOrO18GpB/b/QvEEXctlZk5Xkd7GqXxBo4SJhmc=; b=jSXJvcWBuIotsqPiP9B8fM/XZU PVKvJ5Dopinx+hBm+9+hwhlhCeaSyOF5rfHdm49OD5GeX38nmUPAVk/TVO6DDKeU8dOuevMlZ7EM3 lg4fLLfVmB5r+jPbek7Sj3guMCJdJKJZGLk79DhYwCF0LmnqC/2xzO8ERC7nYMuSYJ798nQQWokYa hQnSmIaHxeTfRzmlY41ARyUCDwu/gV2kwJHtjrqpaVDH2YcRjaLEIPf/7BLQHCsmsvD7GoFbnRqeK EnZSAln9ttqvHoFd+aTEXXwkXmrfcifCGaCgdtWEYk5Mj1pT3Yts+arex0SiMkED4WFr1FcWVq02L fC9gF3yg==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ovPQC-000D8z-4N; Wed, 16 Nov 2022 15:54:12 -0500 In-Reply-To: <878rka1y4n.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 16 Nov 2022 11:46:00 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248051 Archived-At: Hi Eric, Eric Abrahamsen writes: > On 11/16/22 14:18 PM, Thomas Fitzsimmons wrote: >> Hi Eric, >> >> Thanks for filing this. >> >> Eric Abrahamsen writes: >> >>> Address completion in message-mode has stopped working in master, >>> possibly as a result of 0e25a39e69acca0324c326ea8e46b1725594bff5. This >>> has been reported for several contact-management backends that expect to >>> have their completions available with . >>> >>> `completion-at-point-functions' contains '(eudc-capf-complete >>> message-completion-function t) at this point -- `eudc-capf-complete' >>> returns no matches, and no other functions in the list are consulted. >> >> I just checked and I didn't think the recent patch I pushed, >> 0e25a39e6..., should have affected completion-at-point-functions. It >> did change the default of eudc-server-hotlist from `nil' to >> `(("localhost" . ecomplete) ("localhost" . mailabbrev))". I thought >> that should only affect EUDC users who have not customized >> eudc-server-hotlist. >> >> `eudc-capf-complete' was added to `message-mode' in commit >> 620ac6735... I'm pretty sure that commenting out this line in >> message.el will restore prior behaviour, but I don't yet know what prior >> behaviour should be (see below). >> >> (add-hook 'completion-at-point-functions #'message-completion-function nil t) >> >>> On gnus.general, someone using BBDB and corfu reported that this recipe >>> fixed the problem: >>> >>> (setq eudc-server-hotlist '(("localhost" . bbdb))) >>> >>> (add-hook 'message-mode-hook >>> (lambda () >>> (setq-local completion-at-point-functions >>> (delq 'message-completion-function >>> completion-at-point-functions)))) >>> >>> Someone else *not* using corfu reported that that didn't work for them. >>> Dunno. >> >> I'm not sure what the out-of-the-box behaviour here is meant to be. Can >> you make a recipe starting from "emacs -Q" (including adding dummy email >> addresses somewhere) that makes completion work how you want it to? For >> me: >> >> emacs -Q >> C-x m TAB >> >> inserts four spaces and prints in *Messages*: >> >> Loading eudcb-ecomplete...done >> Loading eudcb-mailabbrev...done >> >> (Those are new, due to 0e25a39e6... but I thought should be harmless.) > > Yuck, it's been a long time since I looked at this... > > In emacs -Q, message-mode `completion-at-point-functions' is: > > (eudc-capf-complete message-completion-function t) > > Actually that's what it is in my regular Emacs, as well. All I'd need > for EBDB (and BBDB and everything else) is for > `message-completion-function' to get called, which it isn't. I believe > you could allow this by having `eudc-capf-complete' return nil, or have > `eudc-capf-message-expand-name' return a `(list beg end )' > structure that includes the prop `:exclusive 'no' at the end of it. That > would allow a fallthrough to the next function. Ah, OK, that's what happened then. The most recent patch I pushed made `eudc-server-hotlist' non-nil by default, which makes `eudc-capf-message-expand-name' do something other than return nil. Can you try just (setq eudc-server-hotlist nil) and confirm that avoids the breakage? If it does, I'll revert that part of the patch for now. Thanks, Thomas