bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Lars Magne Ingebrigtsen <larsi@gnus.org>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Sending email 
>> Sending email done
>> smtpmail-send-it: Sending failed: 550 This message scored too many
>> spam points in response to .
>> 
>> So it shouldn't say "done" until it's really done.
>
> Isn't it message.el that says "done" in this case?

I think it must be this code...  I can't find the string "Sending email"
in message.el.

(defun smtpmail-send-data (process buffer)
  (let ((data-continue t) sending-data
        (pr (with-current-buffer buffer
              (make-progress-reporter "Sending email "
                                      (point-min) (point-max)))))
    (with-current-buffer buffer
      (goto-char (point-min)))
    (while data-continue
      (with-current-buffer buffer
        (progress-reporter-update pr (point))
        (setq sending-data (buffer-substring (point-at-bol) (point-at-eol)))
	(end-of-line 2)
        (setq data-continue (not (eobp))))
      (smtpmail-send-data-1 process sending-data))
    (progress-reporter-done pr)))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no