From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches Date: Mon, 15 May 2023 16:40:12 -0400 Message-ID: References: <871qjhs64q.fsf@fedora.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6344"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm To: Fabrice Bauzac-Stehly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 15 22:41:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyf0R-0001UN-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 May 2023 22:41:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyf0C-00040b-C2; Mon, 15 May 2023 16:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyf0A-00040O-Rc for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 16:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyf0A-0007IS-Im for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 16:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyf0A-0005xd-CS for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 16:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62721 X-GNU-PR-Package: emacs Original-Received: via spool by 62721-submit@debbugs.gnu.org id=B62721.168418322022849 (code B ref 62721); Mon, 15 May 2023 20:41:02 +0000 Original-Received: (at 62721) by debbugs.gnu.org; 15 May 2023 20:40:20 +0000 Original-Received: from localhost ([127.0.0.1]:44570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyezT-0005wS-Uh for submit@debbugs.gnu.org; Mon, 15 May 2023 16:40:20 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]:48570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyezS-0005wF-Dh for 62721@debbugs.gnu.org; Mon, 15 May 2023 16:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PStN9MiaC0elWRJRB1XT5YpHgjEakfXPdyi4C0iDcyw=; b=ogsQ4KLR/vHPYiMpp0dcFdZkBR gF/j0Y5EWEskwYgx49aI3XyxKM7qmtLXmESgmjAgq3bcSD304VhvfUKD9pcvisIeTsJ+hBnurGFMt MxfIA+8M3Q0GF3wzL7EACgVKzsrfDatnYLfSd2FP2vJMykj/KVbqgIX3O/qz3vSqCd0FqyPM+7dwF DpptGSSnso7O5B8G1vbjEyQzj38njriyo8xU89MCo6gIX9lRqqJcZHdbOxgIjcSqCs6VA2BjIUecp uI6QDtp0wfSkbdcCAAeZNDC7LtBgYEqNPP2yBFImCu42XyJPNYAl0gLyXeft3MsHOAn5/w8gouoPK BbvloJHA==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pyezN-000DGx-55; Mon, 15 May 2023 16:40:12 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 15 May 2023 16:36:43 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261768 Archived-At: Thomas Fitzsimmons writes: > Fabrice Bauzac-Stehly writes: > >> Hello Thomas, >> >> Thomas Fitzsimmons writes: >> >>> Do you mind posting the `eudc-ldap-no-wildcard-attributes' setting you >>> ended up with? The docstring for that variable doesn't mention >>> adjusting this as a preference, only LDAP failure workarounds. I >>> would like to update the docstring with an example, to make your use >>> case more discoverable. >> >> Sure. I have kept the two default items of the list, and added >> 'samaccountname (the attribute for which I don't want any wildcard). As >> I've used Customize, it appears like this in my ~/.emacs.d/init.el: >> >> '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) > > Thanks, and what field of `eudc-query-form' does that affect? > "E-Mail"? I'll just share my proposed patch. Does the documentation change capture your use case? Thanks, Thomas EUDC: Document disabling default LDAP wildcard expansion * lisp/net/eudc-vars.el (eudc-ldap-no-wildcard-attributes): Cover `eudc-query-form' and `eudc-expand-inline' behavior in the customization docstring. (Bug#62721) diff --git a/lisp/net/eudc-vars.el b/lisp/net/eudc-vars.el index 12f5347bd35..b3aa23f5827 100644 --- a/lisp/net/eudc-vars.el +++ b/lisp/net/eudc-vars.el @@ -441,7 +441,12 @@ eudc-ldap-no-wildcard-attributes "LDAP attributes which are always searched for without wildcard character. This is the list of special dictionary-valued attributes, where wildcarded search may fail. For example, it fails with -objectclass in Active Directory servers." +objectclass in Active Directory servers. + +You may not want functions like `eudc-query-form' and +`eudc-expand-inline' to do LDAP wildcard expansion by default on +certain fields. If so, add the relevant symbol to this list, for +example `samaccountname' for the \"E-Mail\" field." :type '(repeat (symbol :tag "Directory attribute")))