From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#9118: 23.3.50; Don't seed the RNG in message-unique-id Date: Tue, 19 Jul 2011 16:57:27 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1311090722 19642 80.91.229.12 (19 Jul 2011 15:52:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2011 15:52:02 +0000 (UTC) Cc: 9118@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 17:51:58 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QjCaT-0003r8-Ju for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2011 17:51:57 +0200 Original-Received: from localhost ([::1]:39864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjCaS-0000Ux-D3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2011 11:51:56 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:35538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjBqG-0003xw-3H for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2011 11:04:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjBqB-0002kO-N9 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2011 11:04:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjBqB-0002kC-Br for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2011 11:04:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QjBq6-0006SZ-Ui; Tue, 19 Jul 2011 11:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 19 Jul 2011 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9118 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: wontfix Original-Received: via spool by 9118-submit@debbugs.gnu.org id=B9118.131108782524796 (code B ref 9118); Tue, 19 Jul 2011 15:04:02 +0000 Original-Received: (at 9118) by debbugs.gnu.org; 19 Jul 2011 15:03:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QjBpl-0006Rm-Hl for submit@debbugs.gnu.org; Tue, 19 Jul 2011 11:03:45 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QjBpg-0006RU-Jr for 9118@debbugs.gnu.org; Tue, 19 Jul 2011 11:03:40 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QjBpR-0006D9-LU; Tue, 19 Jul 2011 17:03:21 +0200 In-Reply-To: (Leo's message of "Tue, 19 Jul 2011 00:42:10 +0800") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEXXFh78+/e3AQX+/fzv fWniSUjqyryqAAD48Or+//31n4Tyt57////+//7v3tFwuiWvAAACD0lEQVQ4jZXTQYvTQBQA4CEY FDzqyQ1ScvEHiLBIlD2MlwjSQyKuJw9aiu3mUJCcRYVSSmERQaUWxOyCE1wQMUhGFkJAEpnk7KFe FEuwNb/ByWQzSZr14BAyyfvy3ptkCFAU8l3yyNHwlexsdFYzICkklPwzpDrSNJmB7CIqIi/YOZ4M 0wmoPuk742wKFpM1iK+v2Bx05rMavHzPIBh20/OA+CVsLPp5QmrUS3UWf7IppMfVGjh5Bnl68Upc hWA/XfF1VGFj3+gfC0v8j4xl0aMAb5IMJTphZ8EzAgqb9xFC2EiWGCc7FfjmWlCDCLnYdbsfKvAE wgxUhGzjsDMv4R60VAtC+/ARbb+USngMkYOdh9NsU770dkoYQbX7qrjFnypg3T4oWoYYj/MrD5DL UFPzyrRYz33DIYY6pC88Z+vp4RscAkuHn8k57XV2/xshpQB/ry2+jU+aD7LICFnjAsK7bfHWM9k0 +5vGcGTbHMjZNhB/DExTB0Cnn2bFIdYFIFNoAVFDCEoc/C0WN2WaYKOffFUk2hJoB3MgA03FjlIC oXCBQgtodrf4BhmE1wSZ1hoA8SAhVYiO4AR/vCj1kQIdp6J1+MWgtU3W4VIO7xrwlYFY7OqcQ8zg NGmAJ8gtAGqVcoiEluoY0yb4ws16NIuxjDv99TgF+l9NvUacZexKzbjig2aw7HHc2P1veP4X8esQ FQnOWRwAAAAASUVORK5CYII= X-Now-Playing: Coil's _The Ape Of Naples_: "Cold Cell" X-Hashcash: 1:23:110719:9118@debbugs.gnu.org::+QkbXik5kgKLvgcL:000000000000000000000000000000000000000002e1I X-Hashcash: 1:23:110719:sdl.web@gmail.com::L+Z/p6HTkzhouzJq:00000000000000000000000000000000000000000000KdMU X-MailScanner-ID: 1QjBpR-0006D9-LU MailScanner-NULL-Check: 1311692601.75909@xJvrGS4T3o83f5YYwTXCAQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 19 Jul 2011 11:04:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49437 Archived-At: Leo writes: > Function message-unique-id seeds the RNG every time it runs and relies > on its undocumented return value. Should something like this be applied? > > --- a/message.el > +++ b/message.el > @@ -5484,7 +5484,8 @@ > ;; Don't use microseconds from (current-time), they may be unsupported. > ;; Instead we use this randomly inited counter. > (setq message-unique-id-char > - (% (1+ (or message-unique-id-char (logand (random t) (1- (lsh 1 20))))) > + (% (1+ (or message-unique-id-char > + (logand (random most-positive-fixnum) (1- (lsh 1 20))))) Unfortunately, Emacs doesn't seed itself on startup, so (random x) will return the same thing every time you start Emacs. So I don't think changing this is appropriate at this time. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/