From: joakim@verona.se
To: Glenn Morris <rgm@gnu.org>
Cc: 22465@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional
Date: Fri, 06 May 2016 19:50:25 +0200 [thread overview]
Message-ID: <m337pvrs7y.fsf@exodia.verona.se> (raw)
In-Reply-To: <jwoa8jkxao.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 06 May 2016 11:42:39 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Paul Eggert wrote:
>
>> Attached is a proposed patch for this bug. It is not fancy, but it
>> works for me.
>
> Thanks. I wonder if the 'image scrolling method should simply be
> removed, since it doesn't work (to date) and isn't the default.
> Are two methods really needed/useful?
Short version:
It is probably just as well to remove the 'image method.
Long version:
The 'image method was the original scrolling method, which simply makes
a large xwidget and scrolls it using the same method as emacs uses to
scroll images. I liked this method because it was consistent with other
Emacs scrolling.
The 'native method lets webkit do the scrolling.
Originally I used the 'image method myself and added the 'native method
because users wanted it. Now I never use 'image, only 'native.
Perhaps someone still prefers the 'image method though.
>
>> From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001
>> From: Paul Eggert <eggert@cs.ucla.edu>
>> Date: Thu, 5 May 2016 22:44:16 -0700
>> Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> * lisp/xwidget.el (xwidget-webkit-scroll-forward)
>> (xwidget-webkit-scroll-backward): Don't loop if
>> xwidget-webkit-scroll-behavior's value is 'image' (Bug#22465).
>> ---
>> lisp/xwidget.el | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
>> index 19f631f..d64237a 100644
>> --- a/lisp/xwidget.el
>> +++ b/lisp/xwidget.el
>> @@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward
>> (interactive)
>> (if (eq xwidget-webkit-scroll-behavior 'native)
>> (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)
>> - (xwidget-webkit-scroll-forward))) ; FIXME infloop!
>> + (image-forward-hscroll 5)))
>>
>> (defun xwidget-webkit-scroll-backward ()
>> "Scroll webkit backwards.
>> @@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward
>> (interactive)
>> (if (eq xwidget-webkit-scroll-behavior 'native)
>> (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)
>> - (xwidget-webkit-scroll-backward))) ; FIXME infloop!
>> + (image-backward-hscroll 5)))
>>
>>
>> ;; The xwidget event needs to go into a higher level handler
--
Joakim Verona
next prev parent reply other threads:[~2016-05-06 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 23:19 bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Glenn Morris
2016-05-06 5:48 ` Paul Eggert
2016-05-06 15:42 ` Glenn Morris
2016-05-06 17:50 ` joakim [this message]
2016-05-08 0:21 ` Paul Eggert
2016-05-13 8:05 ` joakim
2016-05-13 16:53 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m337pvrs7y.fsf@exodia.verona.se \
--to=joakim@verona.se \
--cc=22465@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).