bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1

[Thomas Fitzsimmons <fitzsim@fitzsim.org>]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

Hi,

An Excorporate user reported an issue when running on Emacs 26.1 that
didn't happen in Emacs 25.3.

The error message, when trying to retrieve calendar items on a given day
is:

soap-find-operation: Wrong type argument: soap-binding, ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding")

The simplest workaround is:

   M-x package-reinstall RET excorporate RET

I narrowed the cause down to what seems to be an incompatibility between
25.x bytecode and 26.1.  This issue only happens when excorporate.elc
has been byte compiled in Emacs 25.x (the .x doesn't seem to matter; I
replicated it on Emacs 25.1) and is then run in Emacs 26.1.  It doesn't
happen with a fresh package install on 25.x or 26.1.

When in the failure state, if I re-eval this function:

(defun exco--bind-wsdl (wsdl service-url port-name target-namespace
                             binding-name)
  "Create a WSDL binding.
Create a binding port for WSDL from SERVICE-URL, PORT-NAME,
TARGET-NAMESPACE and BINDING-NAME."
  (let* ((namespace (soap-wsdl-find-namespace target-namespace wsdl))
         (port (make-soap-port
                :name port-name
                :binding (cons target-namespace binding-name)
                :service-url service-url)))
    (soap-namespace-put port namespace)
    (push port (soap-wsdl-ports wsdl))
    (soap-resolve-references port wsdl)
    wsdl))

everything works.

In terms higher level functionality, it seems like the call to
soap-resolve-references has no effect.

I'm attaching the 25.1 and 26.1 bytecode for this function,
disassembled.  Maybe someone can identify what's wrong or suggest next
steps?

Thank you,
Thomas


[-- Attachment #2: exco--bind-wsdl-dump-25.1.txt --]
[-- Type: text/plain, Size: 908 bytes --]

byte code for exco--bind-wsdl:
  doc:  Create a WSDL binding. ...
  args: (arg1 arg2 arg3 arg4 arg5)
0	constant  soap-wsdl-find-namespace
1	stack-ref 2
2	stack-ref 6
4	call	  2
5	constant  vector
6	constant  cl-struct-soap-port
7	stack-ref 5
8	constant  nil
9	stack-ref 8
11	stack-ref 7
13	stack-ref 7
15	cons	  
16	call	  5
17	constant  soap-namespace-put
18	stack-ref 1
19	stack-ref 3
20	call	  2
21	discard	  
22	stack-ref 6
24	constant  0
25	aref	  
26	varref	  cl-struct-soap-wsdl-tags
27	memq	  
28	goto-if-not-nil 1
31	constant  signal
32	constant  wrong-type-argument
33	constant  soap-wsdl
34	stack-ref 9
36	list2	  
37	call	  2
38	discard	  
39:1	stack-ref 6
41	dup	  
42	constant  4
43	stack-ref 3
44	stack-ref 3
45	constant  4
46	aref	  
47	cons	  
48	aset	  
49	discardN  2
51	constant  soap-resolve-references
52	stack-ref 1
53	stack-ref 8
55	call	  2
56	discard	  
57	stack-ref 6
59	return	  

[-- Attachment #3: exco--bind-wsdl-dump-26.1.txt --]
[-- Type: text/plain, Size: 905 bytes --]

byte code for exco--bind-wsdl:
  doc:  Create a WSDL binding. ...
  args: (arg1 arg2 arg3 arg4 arg5)
0	constant  soap-wsdl-find-namespace
1	stack-ref 2
2	stack-ref 6
4	call	  2
5	constant  record
6	constant  soap-port
7	stack-ref 5
8	constant  nil
9	stack-ref 8
11	stack-ref 7
13	stack-ref 7
15	cons	  
16	call	  5
17	constant  soap-namespace-put
18	stack-ref 1
19	stack-ref 3
20	call	  2
21	discard	  
22	constant  type-of
23	stack-ref 7
25	call	  1
26	varref	  cl-struct-soap-wsdl-tags
27	memq	  
28	goto-if-not-nil 1
31	constant  signal
32	constant  wrong-type-argument
33	constant  soap-wsdl
34	stack-ref 9
36	list2	  
37	call	  2
38	discard	  
39:1	stack-ref 6
41	dup	  
42	constant  4
43	stack-ref 3
44	stack-ref 3
45	constant  4
46	aref	  
47	cons	  
48	aset	  
49	discardN  2
51	constant  soap-resolve-references
52	stack-ref 1
53	stack-ref 8
55	call	  2
56	discard	  
57	stack-ref 6
59	return