From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly Date: Sun, 20 Mar 2016 12:21:09 +0100 Message-ID: References: <87siua8hf1.fsf@violet.siamics.net> <87io998qjn.fsf@gmail.com> <87lh8iz041.fsf@gnus.org> <83k2o1k6z0.fsf@gnu.org> <8737uj7vzw.fsf@gmail.com> <83bn97dgo6.fsf@gnu.org> <87a8m8dafw.fsf@engster.org> <831t7krazs.fsf@gnu.org> <87d1qvwxo0.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458472945 13366 80.91.229.3 (20 Mar 2016 11:22:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2016 11:22:25 +0000 (UTC) Cc: 11788@debbugs.gnu.org, schwab@linux-m68k.org, ivan@siamics.net, David Engster To: Tao Fang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 20 12:22:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahbQy-0005as-Nr for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Mar 2016 12:22:12 +0100 Original-Received: from localhost ([::1]:52383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahbQx-0003iS-MR for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Mar 2016 07:22:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahbQs-0003iH-Pg for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 07:22:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahbQo-0001NB-ER for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 07:22:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahbQo-0001N7-BH for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 07:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ahbQn-0001Lf-Nc; Sun, 20 Mar 2016 07:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, Magnus Henoch Resent-Date: Sun, 20 Mar 2016 11:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11788-submit@debbugs.gnu.org id=B11788.14584728795135 (code B ref 11788); Sun, 20 Mar 2016 11:22:01 +0000 Original-Received: (at 11788) by debbugs.gnu.org; 20 Mar 2016 11:21:19 +0000 Original-Received: from localhost ([127.0.0.1]:54190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahbQ7-0001Kk-LB for submit@debbugs.gnu.org; Sun, 20 Mar 2016 07:21:19 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:54406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahbQ5-0001Kc-5C for 11788@debbugs.gnu.org; Sun, 20 Mar 2016 07:21:17 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1ahbPy-0000kH-AR; Sun, 20 Mar 2016 12:21:12 +0100 In-Reply-To: <87d1qvwxo0.fsf@gmail.com> (Tao Fang's message of "Tue, 15 Mar 2016 23:47:27 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115126 Archived-At: Tao Fang writes: > I've received notice email of the assignment/disclaimer process with the > FSF yesterday, and currently it's complete, please check the file to see > if it's all okay? Your assignment is now on file... > And I've re-format the previous attached patch file and maybe somebody > could helping review, modify and apply it to the repo? Looks basically good, but a few notes: > - (let ((proc (url-open-stream host buf host port gateway-method))) > + (let ((proc (url-open-stream host buf > + (if url-using-proxy (url-host url-using-proxy) host) > + (if url-using-proxy (url-port url-using-proxy) port) > + gateway-method))) Throughout the code, the lines seem to be too long. They should preferably not be more than 80 characters long (unless there's an absolute need). [...] > + (let ((tls-connection (gnutls-negotiate > + :process proc > + :hostname (url-host url-current-object) > + :verify-error nil))) After negotiation, you should probably call `nsm-verify-connection'. Uhm... and that's it. Oh, and a NEWS entry saying that url now supports HTTPS proxies would be nice, and a ChangeLog style commit message. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no