From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#38507: Fwd: Re: eww error: error in process filter: Window system frame should be used Date: Thu, 12 Dec 2019 14:23:33 +0100 Message-ID: References: <3FBA0F50-0551-40F6-B947-A677E7EFBC65@gmail.com> <53D075BF-2A1A-44E2-B420-D4615AFDFDC7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="93006"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , 38507@debbugs.gnu.org To: "A.C." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 12 15:16:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifPGM-000O16-3k for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Dec 2019 15:16:18 +0100 Original-Received: from localhost ([::1]:60182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifPGK-0004o3-Q0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Dec 2019 09:16:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60493) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifORp-00089W-R6 for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 08:24:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifORm-0002Y9-Mw for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 08:24:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifORm-0002Xj-Il for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 08:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ifORm-0002OM-Ez for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 08:24:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <20191206023324.GA20286@system76-pc.localdomain> Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Dec 2019 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38507 X-GNU-PR-Package: emacs Original-Received: via spool by 38507-submit@debbugs.gnu.org id=B38507.15761570239167 (code B ref 38507); Thu, 12 Dec 2019 13:24:02 +0000 Original-Received: (at 38507) by debbugs.gnu.org; 12 Dec 2019 13:23:43 +0000 Original-Received: from localhost ([127.0.0.1]:59193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifORT-0002Nn-8y for submit@debbugs.gnu.org; Thu, 12 Dec 2019 08:23:43 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:51867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifORR-0002NY-D9 for 38507@debbugs.gnu.org; Thu, 12 Dec 2019 08:23:41 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id d73so2353079wmd.1 for <38507@debbugs.gnu.org>; Thu, 12 Dec 2019 05:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:message-id :mime-version; bh=citDXjt6a7bPK5B+njUyMoavkT6CvVpaAWVUVkbwSCM=; b=lBv2Hm0crAVl19oDfd2tOZLyFg9bbKTVDi7A0BgLneso9gaSPpjyJwiJzGJS4TvaAm sn3ASg/qyDqAzpy2B4UJpMFQfIFCCtYBl7b3OgB/0QQu2R85fYKa/Hvp5xyfOYKdRBLW gtavH9xq24j1PwJpC32CFqcHxph+5NCDv+r+zHh6NZLd457eiPN1pNggWBMBlwO1urdO xfTNafhwG3iLuvQViN2ikxW0kUZuJlGuGFJJoY83GO6edPLofxIKV7jiZ3AdRNP+eFrC K8agA49YW8bnOGqpy/g5EqxYV8KPnHNT8tTcAaWTuy9B9ueI989N0HwCqBdhjF75EWon LA3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:message-id:mime-version; bh=citDXjt6a7bPK5B+njUyMoavkT6CvVpaAWVUVkbwSCM=; b=lkTqZ7ahtrj+qyqnB6U4OhR3q6xOw/5B5uwLpvGgE4N5k7LjLcSiyBWgLCj4++QTHt c48lvPwiMNkO8fLjL/SB9aOLUmLhqmNzffj7Y9AayLoW36EwAUrTBKc7ioj1i3j5t8UL ZBwH94EF0jI67XjfHHD5gqCJVBobUoZH644Ul6a56wM6FwIQMWog83T5QS5hMcp0W8ry iMWdt3eOnGityWMPR7fsU5Q7l+KlWKxJaxxKi6drdnnPPykuG8CTqjdU6qcWQw2QZaeW rKnCXmVMY5M4VG/4c5Uwa+l1cZBFXFBXBTIvUjQ73q1FZNwHwkMsKhvbz1Ypg0LlXiWi +fxw== X-Gm-Message-State: APjAAAUKzdzPyWqSJAKchSB+aRZqzcXEHdvBnz3dW0qxpqcm3LEU2ShH YBv3lqCXxwafPQMBd4DJFRk= X-Google-Smtp-Source: APXvYqw4Ws1D9pqDU0KPVfWOvxODAiaFsWQR391ij8hjXLoekhDYVhPIzupkitLONSNjwtNKqBvRDw== X-Received: by 2002:a7b:c7d3:: with SMTP id z19mr6457747wmk.94.1576157015181; Thu, 12 Dec 2019 05:23:35 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 4sm6074213wmg.22.2019.12.12.05.23.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2019 05:23:34 -0800 (PST) Gmane-Reply-To-List: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173220 Archived-At: >>>>> On Fri, 06 Dec 2019 00:11:54 -0500, "A.C." said: AC> -------- Original Message -------- AC> From: "A.C." AC> Sent: December 6, 2019 12:09:46 AM EST AC> To: bug-gnu-emacs@gnu.org AC> Subject: Re: eww error: error in process filter: Window system frame should be used AC> To follow up with some more info: AC> As the trace indicates, the problem seems to be caused by an svg image AC> that website tries to load. This happens only when I start emacs in a AC> terminal (with the '-nw' flag). The website loads fine AC> - when emacs runs in an x window (so plain 'emacs' rather than 'emacs -nw'); AC> - in a terminal, provided I disable svg images with AC> (setq shr-blocked-images "svg") AC> So there are ways around this, but surely eww could handle AC> this more gracefully? Perhaps with the right combination of AC> compile config options? Eww really shouldn't try to display images when running in terminal mode. This should do it, unless Lars can suggest something better: diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 22d4cde34a..aec4a9e465 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1197,8 +1197,9 @@ shr-parse-image-data (libxml-parse-xml-region (point) (point-max)) 'utf-8))) ;; SVG images often do not have a specified foreground/background ;; color, so wrap them in styles. - (when (eq content-type 'image/svg+xml) - (setq data (svg--wrap-svg data))) + (and (display-graphic-p) + (eq content-type 'image/svg+xml) + (setq data (svg--wrap-svg data))) (list data content-type))) (defun svg--wrap-svg (data)