From: Robert Pluim <rpluim@gmail.com>
To: philip@warpmail.net (Philip K.)
Cc: 40355@debbugs.gnu.org
Subject: bug#40355: [PATCH] Implement caching for libravatar lookup
Date: Wed, 01 Apr 2020 09:27:00 +0200 [thread overview]
Message-ID: <m2zhbvzmwr.fsf@gmail.com> (raw)
In-Reply-To: <87d08sp5zk.fsf@bulbul> (Philip K.'s message of "Tue, 31 Mar 2020 23:30:23 +0200")
>>>>> On Tue, 31 Mar 2020 23:30:23 +0200, philip@warpmail.net (Philip K.) said:
Philip> Robert Pluim <rpluim@gmail.com> writes:
>>>>>>> On Tue, 31 Mar 2020 20:03:36 +0200, Philip K <philip@warpmail.net> said:
>>
>> I doubt you need the 'cache' arg, you can keep the cache purely
>> internal.
Philip> I added it because I was considering defining gravatar-libravatar-cache
Philip> as
Philip> (let ((cache (make-hash-table :test 'equal)))
Philip> (dolist (domain '("aol.com" "att.net" "comcast.net" "facebook.com"
Philip> "gmail.com" "gmx.com" "googlemail.com" "google.com"
Philip> "hotmail.com" "hotmail.co.uk" "mac.com" "me.com"
Philip> "mail.com" "msn.com" "live.com" "sbcglobal.net"
Philip> ;; ...
Philip> ))
Philip> (gravatar--service-libravatar (concat "ignored@" domain) cache))
Philip> cache)
Philip> with a few popular domains. The only issue is that evaluating it takes
Philip> forever.
Perhaps thatʼs a sign that pre-population is not needed :-)
>> How big is this cache likely to get? Perhaps use a weak hash table?
Philip> I haven't managed to gather good real-world data yet, but I would assume
Philip> something along the lines of 50-200 domains?
OK, I donʼt think thatʼs onerous.
Robert
next prev parent reply other threads:[~2020-04-01 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 18:03 bug#40355: [PATCH] Implement caching for libravatar lookup Philip K
2020-03-31 19:58 ` Robert Pluim
2020-03-31 21:30 ` Philip K.
2020-04-01 7:27 ` Robert Pluim [this message]
2020-04-01 10:34 ` Philip K.
2020-08-08 13:03 ` Lars Ingebrigtsen
2020-08-18 14:46 ` Lars Ingebrigtsen
2020-08-24 14:09 ` Robert Pluim
2020-08-24 14:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zhbvzmwr.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=40355@debbugs.gnu.org \
--cc=philip@warpmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).