From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#42397: [PATCH 01/14] ; * lisp/epg.el (epg-signature-to-string): Use cl-case. Date: Thu, 16 Jul 2020 19:22:13 +0200 Message-ID: References: <20200716144707.16857-1-jonas@bernoul.li> <20200716145456.17531-1-jonas@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10712"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42397@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 19:23:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw7bC-0002d5-0M for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 19:23:10 +0200 Original-Received: from localhost ([::1]:37716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw7bA-00087p-SM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 13:23:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw7b4-00087L-2Y for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 13:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw7b3-0000so-MW for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 13:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw7b3-0002pO-K0 for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 13:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42397-submit@debbugs.gnu.org id=B42397.159492014310825 (code B ref 42397); Thu, 16 Jul 2020 17:23:01 +0000 Original-Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 17:22:23 +0000 Original-Received: from localhost ([127.0.0.1]:55885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7aR-0002oX-Ca for submit@debbugs.gnu.org; Thu, 16 Jul 2020 13:22:23 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:38839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7aP-0002oI-JE for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 13:22:22 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id f18so12320026wml.3 for <42397@debbugs.gnu.org>; Thu, 16 Jul 2020 10:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=2wDvI6X3RVfEc9Yu5fOLxc3r+iH8K59p9rV104M1H1k=; b=JA1QJ0vOBu0q6YLTUHozwiLfjr+X7JeO8okIJW5+6e+cYUEXG495TjrJURefSUlhzs /n02MHP2nw62+ZHOxKwe8qRemO9GtmuwYoT0skaljdVwTtw+L/aToTou+Dt64Gpz1+7Q K+IqKjndwYltgEo93toQ36kmKDl2BDZfSmqaECzif96s9wlOkEXwezqCHFnt4F1t42Vp ASq+EctJhto2mrRMhtdimmXR1C+VdIeHrBNYSVPtCbYMOwfWnlBQZNMuuU+rgn7lfka+ 3JWOdTzWAWW/rmO9mWtx6WHUd9EfvjO1RTxKSFaRkxqHHcBnnrxJq1MBeOmqy0DUNvih waeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=2wDvI6X3RVfEc9Yu5fOLxc3r+iH8K59p9rV104M1H1k=; b=XNUA3eO3nqMUgyxvjwUbHu9VqjWDG1nOPLXPJWwTqaRd+B0dbVe9m9zPqShhqBK0sB U+ZIK6Gby6fYLFHvkOKou9j9IPpGsFpt+2HNnZ+T4lEOSkmfxFItwLISppZ+qo8Xx1e0 vIX24W/3xf0V0oSENrhPpIkc72CMbpifdM2qmAcVP9O8CuePZpu7j4o7/HTEHKsvNnJK RFmxfHLfNydQBlqwfAxekVmM7qCKLyGPS3NCSiEPWhDP5e9vE1nFihwjNAxahVeEVMl2 PHXssIL+I2ZpAyBlF/Gb37QYfLeOgHPh6Q3UpRsUHdLfgX4PdDy4RwtHZSeg97INvC18 MW+g== X-Gm-Message-State: AOAM533v+sw4k9PpdNPOVBVH2esBp3V8GZQn0TIWz8dpSdo/2hcvPbvG LYwD62EdNbjHbycMQydZRG4FroppcHhXTQ== X-Google-Smtp-Source: ABdhPJzTi3mZ6rwZT23jRHjRlhcTTY8jOwfQgwnA51FQEaTLJ6D7Zq4328uYXtyBNj4OknuQWAuF4g== X-Received: by 2002:a1c:ed01:: with SMTP id l1mr5352444wmh.33.1594920135121; Thu, 16 Jul 2020 10:22:15 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:6c9b:b312:5489:40ad]) by smtp.gmail.com with ESMTPSA id j4sm10539543wrp.51.2020.07.16.10.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 10:22:14 -0700 (PDT) In-Reply-To: <20200716145456.17531-1-jonas@bernoul.li> (Jonas Bernoulli's message of "Thu, 16 Jul 2020 16:54:43 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183092 Archived-At: >>>>> On Thu, 16 Jul 2020 16:54:43 +0200, Jonas Bernoulli said: Jonas> In this case we can greatly increase readability by using `cl-case' Jonas> instead of `cond'. Jonas> --- Jonas> lisp/epg.el | 19 +++++++------------ Jonas> 1 file changed, 7 insertions(+), 12 deletions(-) Jonas> diff --git a/lisp/epg.el b/lisp/epg.el Jonas> index 222fd913e1..e97db65b60 100644 Jonas> --- a/lisp/epg.el Jonas> +++ b/lisp/epg.el Jonas> @@ -404,18 +404,13 @@ epg-signature-to-string Jonas> (pubkey-algorithm (epg-signature-pubkey-algorithm signature)) Jonas> (key-id (epg-signature-key-id signature))) Jonas> (concat Jonas> - (cond ((eq (epg-signature-status signature) 'good) Jonas> - "Good signature from ") Jonas> - ((eq (epg-signature-status signature) 'bad) Jonas> - "Bad signature from ") Jonas> - ((eq (epg-signature-status signature) 'expired) Jonas> - "Expired signature from ") Jonas> - ((eq (epg-signature-status signature) 'expired-key) Jonas> - "Signature made by expired key ") Jonas> - ((eq (epg-signature-status signature) 'revoked-key) Jonas> - "Signature made by revoked key ") Jonas> - ((eq (epg-signature-status signature) 'no-pubkey) Jonas> - "No public key for ")) Jonas> + (cl-case signature Jonas> + (good "Good signature from ") Jonas> + (bad "Bad signature from ") Jonas> + (expired "Expired signature from ") Jonas> + (expired-key "Signature made by expired key ") Jonas> + (revoked-key "Signature made by revoked key ") Jonas> + (no-pubkey "No public key for ")) Did you drop the `epg-signature-status' accessor on purpose here? Robert