unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: 43724@debbugs.gnu.org
Cc: rgm@gnu.org, michael.albinus@gmx.de
Subject: bug#43724: build failure in dbusbind
Date: Thu, 01 Oct 2020 10:49:06 +0200	[thread overview]
Message-ID: <m2zh561gcd.fsf@gmail.com> (raw)
In-Reply-To: <874knee418.fsf@gmx.de> (Michael Albinus's message of "Thu, 01 Oct 2020 10:36:35 +0200")

>>>>> On Thu, 01 Oct 2020 10:36:35 +0200, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Lars Ingebrigtsen <larsi@gnus.org> writes:
    >> Glenn Morris <rgm@gnu.org> writes:
    >> 
    >>> On CentOS 8.2 with gcc 8.3.1 at a190a446e with
    >>> --enable-check-lisp-object-type:
    >> 
    >> Just a data point -- this also fails for me on Debian bullseye with
    >> 
    >> gcc version 10.2.0 (Debian 10.2.0-6)

    Michael> Same error happens here when configuring Emacs with
    Michael> --enable-check-lisp-object-type. So I've reverted my last change, using
    Michael> SYMBOLP instead of Fkeywordp. Closing the bug.

    Michael> But I must admit that I don't understand why Fkeywordp triggers that
    Michael> error.

    Michael> Best regards, Michael.

From lisp.h

/* A Lisp_Object is a tagged pointer or integer.  Ordinarily it is a
   Lisp_Word.  However, if CHECK_LISP_OBJECT_TYPE, it is a wrapper
   around Lisp_Word, to help catch thinkos like 'Lisp_Object x = 0;'.

which means you should be using the NILP macro rather than checking
the return value of Fkeywordp directly, I think.

Robert
-- 





      parent reply	other threads:[~2020-10-01  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 15:40 bug#43724: build failure in dbusbind Glenn Morris
2020-09-30 17:34 ` Lars Ingebrigtsen
2020-10-01  8:36   ` Michael Albinus
2020-10-01  8:45     ` Andreas Schwab
2020-10-01  9:22       ` Michael Albinus
2020-10-01  8:49     ` Robert Pluim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2zh561gcd.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=43724@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).