From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Tue, 01 Jun 2021 08:57:05 -0700 Message-ID: References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> <878s3uf6ij.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="312"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 48683@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 01 17:58:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo6mS-000AOa-7A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Jun 2021 17:58:12 +0200 Original-Received: from localhost ([::1]:46480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo6mR-0006du-0C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Jun 2021 11:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo6mI-0006cn-D8 for bug-gnu-emacs@gnu.org; Tue, 01 Jun 2021 11:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lo6mI-0007lQ-5Z for bug-gnu-emacs@gnu.org; Tue, 01 Jun 2021 11:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lo6mI-00061q-4s for bug-gnu-emacs@gnu.org; Tue, 01 Jun 2021 11:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Jun 2021 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48683-submit@debbugs.gnu.org id=B48683.162256303323101 (code B ref 48683); Tue, 01 Jun 2021 15:58:02 +0000 Original-Received: (at 48683) by debbugs.gnu.org; 1 Jun 2021 15:57:13 +0000 Original-Received: from localhost ([127.0.0.1]:37634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo6lU-00060X-MD for submit@debbugs.gnu.org; Tue, 01 Jun 2021 11:57:12 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:40391 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo6lQ-00060N-V3 for 48683@debbugs.gnu.org; Tue, 01 Jun 2021 11:57:11 -0400 Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:c5ce:264e:3af5:9738]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FvcH60hbQz3pdmR; Tue, 1 Jun 2021 08:57:06 -0700 (PDT) In-Reply-To: <878s3uf6ij.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Jun 2021 08:23:00 +0200") Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207792 Archived-At: Lars Ingebrigtsen writes: > Alex Bochannek writes: > >>> It seems like many people would prefer to have the `#' command be a >>> toggle. Perhaps we should just add a user option to have `#' toggle or >>> not? (Defaulting to "not toggle" for backwards compatibility.) >> >> How about something like this? > > Looks good. Some small comments: > >> +(defcustom gnus-summary-process-mark-toggle nil > > Perhaps this should be gnus-process-mark-toggle and also work in the > Group buffer? That makes sense and I can look at that. I have not dug into the differences between group and topic mode, but I hope they are similar enough. >> + (if (eq t unmark) >> + (gnus-summary-remove-process-mark article) >> + (if (eq t gnus-summary-process-mark-toggle) > > We shouldn't check against t in either of these cases -- any non-nil > value is valid. Good point, thank you! -- Alex.