From: Alex Bochannek <alex@bochannek.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 48683@debbugs.gnu.org
Subject: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable
Date: Tue, 01 Jun 2021 08:57:05 -0700 [thread overview]
Message-ID: <m2zgw9r31q.fsf@bochannek.com> (raw)
In-Reply-To: <878s3uf6ij.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Jun 2021 08:23:00 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Alex Bochannek <alex@bochannek.com> writes:
>
>>> It seems like many people would prefer to have the `#' command be a
>>> toggle. Perhaps we should just add a user option to have `#' toggle or
>>> not? (Defaulting to "not toggle" for backwards compatibility.)
>>
>> How about something like this?
>
> Looks good. Some small comments:
>
>> +(defcustom gnus-summary-process-mark-toggle nil
>
> Perhaps this should be gnus-process-mark-toggle and also work in the
> Group buffer?
That makes sense and I can look at that. I have not dug into the
differences between group and topic mode, but I hope they are similar
enough.
>> + (if (eq t unmark)
>> + (gnus-summary-remove-process-mark article)
>> + (if (eq t gnus-summary-process-mark-toggle)
>
> We shouldn't check against t in either of these cases -- any non-nil
> value is valid.
Good point, thank you!
--
Alex.
next prev parent reply other threads:[~2021-06-01 15:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 19:57 bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Alex Bochannek
2021-05-27 23:28 ` Lars Ingebrigtsen
2021-05-28 0:13 ` Jose A. Ortega Ruiz
2021-05-28 2:07 ` Eric Abrahamsen
2021-05-28 2:16 ` Lars Ingebrigtsen
2021-05-28 2:29 ` Eric Abrahamsen
2021-05-28 17:39 ` Jose A. Ortega Ruiz
2021-05-28 2:04 ` Alex Bochannek
2021-05-29 2:18 ` Lars Ingebrigtsen
2021-05-29 16:59 ` Eric Abrahamsen
2021-05-30 4:32 ` Lars Ingebrigtsen
2021-05-31 20:33 ` Alex Bochannek
2021-06-01 6:23 ` Lars Ingebrigtsen
2021-06-01 15:57 ` Alex Bochannek [this message]
2021-06-01 20:45 ` Alex Bochannek
2021-06-02 5:42 ` Lars Ingebrigtsen
2021-06-02 6:35 ` Alex Bochannek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zgw9r31q.fsf@bochannek.com \
--to=alex@bochannek.com \
--cc=48683@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).