From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Y. E. via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50491: [PATCH] Re: bug#50491: 28.0.50; load-theme in early-init does not fully loads/enables expected faces Date: Wed, 15 Sep 2021 13:22:34 +0300 Message-ID: References: Reply-To: "Y. E." Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50491@debbugs.gnu.org, yet@ego.team To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 15 12:23:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQS4R-00010q-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 12:23:15 +0200 Original-Received: from localhost ([::1]:60496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQS4P-0005PD-Vn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 06:23:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQS4E-0005Ia-Qq for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 06:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQS4E-00040T-I4 for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 06:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQS4E-0003Sv-95 for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 06:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Y. E. Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Sep 2021 10:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50491 X-GNU-PR-Package: emacs Original-Received: via spool by 50491-submit@debbugs.gnu.org id=B50491.163170136213282 (code B ref 50491); Wed, 15 Sep 2021 10:23:02 +0000 Original-Received: (at 50491) by debbugs.gnu.org; 15 Sep 2021 10:22:42 +0000 Original-Received: from localhost ([127.0.0.1]:50954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQS3u-0003SA-Dg for submit@debbugs.gnu.org; Wed, 15 Sep 2021 06:22:42 -0400 Original-Received: from out1.migadu.com ([91.121.223.63]:44509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQS3s-0003S0-0v for 50491@debbugs.gnu.org; Wed, 15 Sep 2021 06:22:42 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ego.team; s=key1; t=1631701358; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to; bh=UvDhHMIqa3qiNGDpkG+H3NB6vFefOVciLNIPAUKTmMI=; b=kLqOQGeVqkKPaOHQlSH0F2Y/IfZOeW+OoamhDb61orXUpIoXnwlhiniFfCRYJtdFnJ5/Ow 557ci3yhZi7OiKqqjpLB/uLPldZTvGcchbUOD4KPWOFm5DMDE4qebvmjyqUGfvUrWu+WrY 82ydhZGziJki+ukQ6T8YPkeZRAFXHJM= In-Reply-To: <838s02exp4.fsf@gnu.org> (message from Eli Zaretskii on Sun, 12 Sep 2021 16:21:43 +0300) X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: yuga@ego.team X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , Y. E. Xref: news.gmane.io gmane.emacs.bugs:214380 Archived-At: --=-=-= Content-Type: text/plain Suggested changes: 1. > The early-init file is not meant to support every single > customization of Emacs, only those that must be done before loading > init.el. Then I suggest replacing "desirable" with "necessary" or a similar word with the meaning "cannot avoid". 2. Optionally, consider adjusting the wording at the beginning of the second paragraph. It sounded perfect until the later commit 4118297ae2f added an intro phrase (an extracted version of the second paragraph). Current getting back to the same topic, after discussing another detail in the mid, without reference to the already expressed idea breaks smooth perception. **** Regardless of the changes, please let me know if the patch formatted/sent the way you'd normally would expect (prefer) it to be done. I followed CONTRIBUTE guidelines (the file contains a lot of information, so I might have missed something), used 'git format-patch', and sent the patch as an attachment via Rmail ('C-c C-a'). Particularly: The patch itself seems got a whitespace added at the end of file, even though there's no such whitespace in the diff/commit I have locally. Is it expected behavior? Thank you. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-doc-emacs-custom.texi-Early-Init-Improve-wording-Bug.patch Content-Description: ; * doc/emacs/custom.texi (Early Init): Improve wording (Bug#50491) >From 1821e64673e86565ab870bc4ff6f8d897c2ea2cf Mon Sep 17 00:00:00 2001 From: YE Date: Wed, 15 Sep 2021 12:23:15 +0300 Subject: [PATCH] ; * doc/emacs/custom.texi (Early Init): Improve wording (Bug#50491) --- doc/emacs/custom.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/emacs/custom.texi b/doc/emacs/custom.texi index 9220a2078f..564393e17e 100644 --- a/doc/emacs/custom.texi +++ b/doc/emacs/custom.texi @@ -2807,7 +2807,7 @@ Early Init File @cindex early init file Most customizations for Emacs should be put in the normal init file. -@xref{Init File}. However, it is sometimes desirable +@xref{Init File}. However, it is sometimes necessary to have customizations that take effect during Emacs startup earlier than the normal init file is processed. Such customizations can be put in the early init file, @file{~/.config/emacs/early-init.el} or @file{~/.emacs.d/early-init.el}. This file is loaded before the @@ -2819,7 +2819,7 @@ Early Init File making already-installed packages available, may be customized in the regular init file. @xref{Package Installation}. - We do not recommend that you move into @file{early-init.el} + We emphasize again, that it is not recommended to move into @file{early-init.el} customizations that can be left in the normal init files. That is because the early init file is read before the GUI is initialized, so customizations related to GUI features will not work reliably in -- 2.30.0 --=-=-=--