From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Date: Tue, 03 Oct 2023 22:03:10 +0200 Message-ID: References: Reply-To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 03 22:04:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnlcw-0000lA-LQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Oct 2023 22:04:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnlcS-0000FF-QA; Tue, 03 Oct 2023 16:03:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnlcP-0000EW-S0 for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 16:03:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnlcP-0004Bs-Jr for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 16:03:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnlcg-0004Mc-I5 for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 16:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2023 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60830 X-GNU-PR-Package: emacs Original-Received: via spool by 60830-submit@debbugs.gnu.org id=B60830.169636342016747 (code B ref 60830); Tue, 03 Oct 2023 20:04:02 +0000 Original-Received: (at 60830) by debbugs.gnu.org; 3 Oct 2023 20:03:40 +0000 Original-Received: from localhost ([127.0.0.1]:40746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnlcK-0004M2-0q for submit@debbugs.gnu.org; Tue, 03 Oct 2023 16:03:40 -0400 Original-Received: from qs51p00im-qukt01071902.me.com ([17.57.155.9]:10675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnlcI-0004Lo-0g for 60830@debbugs.gnu.org; Tue, 03 Oct 2023 16:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696363395; bh=cNURo4Qa+xUBeAU/sWV+rG40iRJULSiPoPPa8Vz+mO8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Il0EM7JNBHlSeR7nmwnR+mFHv9dnBYhVeIh8FdM92XE/RPSxn4HMv+SL8O96l+Vxb PN1OJSiij2bS2JrBd7/iis/GQJrwEpYyM8CHXTTtol4y0YbDBOBwxwHrSqbtQgMY8o s8UFIQo+WrhBzvSlM7YOdID2CMeNrwz3hMelvRV2vxAOv0+JpFUa4Li9XfiNt/btKL Xxsq2Q8KtT2q32LHfgKVi6n4cgIhlUW0nP/pIloBvlCQFQWwiefa1Z4wix9IkJdn/m YQ2M/VzmYkXYOlGQPJcjNcr6Kn9K0m5S/Q9jIFbtoZLjeOYOh3EthzWav8sRAXH8G2 7+jcGrgWczv7Q== Original-Received: from Rudolfs-MacBook-Air.local (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01071902.me.com (Postfix) with ESMTPSA id 25ADA5EC045D; Tue, 3 Oct 2023 20:03:13 +0000 (UTC) In-Reply-To: X-Proofpoint-ORIG-GUID: GaFcBOSDmP_LcBewiyA_L2Sg_6ORPxUF X-Proofpoint-GUID: GaFcBOSDmP_LcBewiyA_L2Sg_6ORPxUF X-Proofpoint-Virus-Version: vendor=fsecure engine=1.1.170-22c6f66c430a71ce266a39bfe25bc2903e8d5c8f:6.0.425, 18.0.790, 17.0.605.474.0000000 definitions=2022-01-12_03:2022-01-11_01, 2022-01-12_03, 2020-01-23_02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=746 malwarescore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310030150 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271734 Archived-At: Stefan Kangas writes: >> (A) Even if the GNU standard supported tab-indented errors, as per (2), >> it would not help, as Lua stack frames are not errors. > > Yes, I noticed that too. Is it a regression with regards to earlier > versions of Emacs? I was unclear in what I wrote. Let me clarify. What I meant is that every Lua error is followed by a stack trace indented with a tab character. From the point of view of a Compilation buffer, each such Lua error consists of exactly one *error* and sequence of stack frames, each of which is an *info*. Note that my patch handles all this correctly, and the tests exercise both cases, errors and stack frames, and they exercise each case twice, once with different data, to make sure all works now and in the future. > I see the benefit of doing that, but I wouldn't say it so strongly that > we "must" do it. We could also just say that people that want these > errors detected should upgrade lua. Note that people would also need to > upgrade Emacs, to get this support. It was a "mathematical" must, as in "we must find X such that..." :) As for upgrading Lua, please know that Lua is different from other languages in that it introduces breaking changes even between minor versions. This does not break all Lua projects because the language is nothing but a single ANSI C compilation unit [*] that will work forever. In practice, if a Lua project has zero dependencies, or perhaps only a few, the maintainers do not ever need to upgrade Lua. This is a key feature of Lua, not a bug. Thus, if Emacs wants to serve Lua developers well, it must recognize errors from older Lua versions as well. [*] When compiled via the 'one.c', otherwise it is multiple files. Rudy --=20 "Programming reliably -- must be an activity of an undeniably mathematical nature [=E2=80=A6] You see, mathematics is about thinking, and doing mathematics is always trying to think as well as possible." -- Edsger W. Dijkstra, 1981 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia