From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andrew Hyatt Newsgroups: gmane.emacs.bugs Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Date: Tue, 26 Jan 2016 00:21:51 -0500 Message-ID: References: <4A1FF55B.4040202@genarts.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1453785745 28769 80.91.229.3 (26 Jan 2016 05:22:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jan 2016 05:22:25 +0000 (UTC) Cc: 3418@debbugs.gnu.org To: Gary Oberbrunner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 26 06:22:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aNw50-0007cz-Jw for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 06:22:14 +0100 Original-Received: from localhost ([::1]:41969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNw4v-0000k0-WC for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 00:22:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNw4r-0000je-Qx for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 00:22:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNw4o-0007LG-Jt for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 00:22:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNw4o-0007L9-GA for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 00:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aNw4o-0001os-8f for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 00:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2016 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3418-submit@debbugs.gnu.org id=B3418.14537857216987 (code B ref 3418); Tue, 26 Jan 2016 05:22:02 +0000 Original-Received: (at 3418) by debbugs.gnu.org; 26 Jan 2016 05:22:01 +0000 Original-Received: from localhost ([127.0.0.1]:36534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNw4n-0001od-DR for submit@debbugs.gnu.org; Tue, 26 Jan 2016 00:22:01 -0500 Original-Received: from mail-qg0-f51.google.com ([209.85.192.51]:34975) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNw4l-0001oQ-Cw for 3418@debbugs.gnu.org; Tue, 26 Jan 2016 00:21:59 -0500 Original-Received: by mail-qg0-f51.google.com with SMTP id o11so127368405qge.2 for <3418@debbugs.gnu.org>; Mon, 25 Jan 2016 21:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=GwIuC70tPWeLowSfPnpXBD+rNPjEtMgt8KIy/SCDn8M=; b=TywwXHpWzyi58mmaxd81xcaEc5/l0cPNwq/v/NGio53f+3LSjamUW3hkFnGNGEVv66 Nb/K6sh7j8iF8v+6do758PrZS1BBO5f4YqQ+uIMM58HrMplgxuzGmO+eSRP2tie8bCV7 cgVxczECGdhVxPHvMM4d/HjhiXFuQkhOgaq4KneXCr4xBkfjMjxB31rfPf3jUWpMuRZA WqNIOsF0YaQPtZrJO8sFSwODZg9hq2YZQduMvNVEGUDk2XOweHv6Pqm5m8yYdjAmIh8d Btk8D6v1phUi56V1GCI6J4B4pirA+1WJFWOTefBMTYBf7Q/w2bKzV4i/tSBKvPoMKhdX bE7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=GwIuC70tPWeLowSfPnpXBD+rNPjEtMgt8KIy/SCDn8M=; b=C7GKn5tQ/mZRl1RU9yGlJT66G9zHd5T1tBayQcS0b8+DPaw+HBjOeVAq+DZptEfUz3 JoGBQ1P+AD/Gqfan5PiSx0tx+0ufLVB2B9KxXiFnGhdB8rQAlz6Z8VqAD9sia3jd6KxE 97HmXcFKQ1dQPw/6LhMLwHQQHZXq/pfNyYSAf1sdOSAF8a1Zs/n15jPSFEBIwm5ZhPyf sBH4rqCn0xWWt9PisZopJM46jTzdA4H12SeVntVrmwvqPZXV7G2sjRV2/QDN4ZejqLnF OvGFeI2H4L7TRriqMPfuTpubcpON1x/xaUdgjMrQowBZ5xSuLwGEIKbwA4b+/PCpcJk3 VRmw== X-Gm-Message-State: AG10YOQP3V9i2/5DBaPU6us7biJlyAAo2YKMf2mWfUE8o8bQ69evGS/BdS0tR7tsHn+0tw== X-Received: by 10.55.204.80 with SMTP id r77mr26910780qki.25.1453785714067; Mon, 25 Jan 2016 21:21:54 -0800 (PST) Original-Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id y129sm10199773qka.33.2016.01.25.21.21.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jan 2016 21:21:53 -0800 (PST) In-Reply-To: <4A1FF55B.4040202@genarts.com> (Gary Oberbrunner's message of "Fri, 29 May 2009 10:46:51 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111976 Archived-At: Gary Oberbrunner writes: > Hi emacs folks. I submitted a patch to compilation-get-file-structure in > compile.el in 2001, introducing this stanza: > > ;; If compilation-parse-errors-filename-function is > ;; defined, use it to process the filename. > (when compilation-parse-errors-filename-function > (setq filename > (funcall > filename))) > > At some point since then, the filename was changed to not always be absolute; > there's now a variable spec-directory in that function. This means that > implementations of compilation-parse-errors-filename-function can't always work > correctly since it doesn't know the full path of the file. > > I'm happy to work on a fix, but I see a few issues. > > Solution 1: add 2nd arg SPEC-DIRECTORY to > compilation-parse-errors-filename-function. > Problem: existing implementations will get an incorrect number of args error and > will have to change. > > Solution 2: make filename absolute before passing to > compilation-parse-errors-filename-function. > Problem: the rest of the code is pretty careful not to absolutize the filename; > this would change the behavior in ways I don't completely understand. > > Of course I am personally happy with solution 1, but since it affects > compatibility I thought I should bring it up on this list. I am not on the > list, so please cc me with any replies, thanks! Sadly, this bug hasn't been responded to. Your description is pretty code-intensive, for those of us not familiar with the internals, can you give instructions on how to reproduce a user-visible issue?