From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles Date: Sun, 30 Sep 2018 17:45:06 +0200 Message-ID: References: <5BADDC88.7010206@gmx.at> Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1538322071 21773 195.159.176.226 (30 Sep 2018 15:41:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2018 15:41:11 +0000 (UTC) Cc: 31240@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 30 17:41:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6dqC-0005Xb-7L for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2018 17:41:04 +0200 Original-Received: from localhost ([::1]:55898 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6dsI-0008OM-P4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2018 11:43:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6dsB-0008Nb-CR for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 11:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6ds6-0007tm-7f for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 11:43:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6ds5-0007tO-Vk for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 11:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g6ds5-00064c-Q0 for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 11:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Sep 2018 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31240-submit@debbugs.gnu.org id=B31240.153832213223262 (code B ref 31240); Sun, 30 Sep 2018 15:43:01 +0000 Original-Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 15:42:12 +0000 Original-Received: from localhost ([127.0.0.1]:60127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6drI-000638-28 for submit@debbugs.gnu.org; Sun, 30 Sep 2018 11:42:12 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:53111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6drG-00062v-Bc for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 11:42:11 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id D86DA2287C for <31240@debbugs.gnu.org>; Sun, 30 Sep 2018 15:46:00 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1538322359; x=1539186360; bh=xu 264im6l3vEzvO0SB743xQYAYxpgVPTgQw0zS42uMA=; b=F3WeOz3HwZt8XyCnig JFMTYP5hnUSIFYkUfFPZu5REIwM2hNes2SkXFSLVTfLUvEGWmYCTArAhQKS5mOvJ O3G0kDZ6gRlbf0T7wtf8X0jEuhdygxc8jCEK4SHsqJ0KZiKePTGahB0jSRqLrdSU 6Tw+QF30OSRg78qXswTRwP2FU= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cjaKsHmyfxzO for <31240@debbugs.gnu.org>; Sun, 30 Sep 2018 15:45:59 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id B94C5226F4; Sun, 30 Sep 2018 15:45:59 +0000 (UTC) In-reply-to: (message from Federico Tedin on Sat, 29 Sep 2018 20:18:59 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150823 Archived-At: Thanks for the updated patch, it looks good to me. I have one small suggestion: > +(defun rectangle-position-as-coordinates (position) > + "Return an integer buffer position as a (COL . LINE) coordinate." > + (save-excursion > + (goto-char position) > + (let ((col (current-column)) > + (line (progn > + (beginning-of-line) > + (count-lines 1 position)))) > + (cons col line)))) (beginning-of-line) could be replaced with (forward-line 0), which is guaranteed to be at the beginning of the line.