From: Robert Pluim <rpluim@gmail.com>
To: Damien Cassou <damien@cassou.me>
Cc: 37470@debbugs.gnu.org
Subject: bug#37470: 26.3; [PATCH] Default value and type of message-make-forward-subject-function
Date: Fri, 20 Sep 2019 12:02:15 +0200 [thread overview]
Message-ID: <m2y2yjz3o8.fsf@gmail.com> (raw)
In-Reply-To: <8736grwd0l.fsf@cassou.me> (Damien Cassou's message of "Fri, 20 Sep 2019 11:08:42 +0200")
>>>>> On Fri, 20 Sep 2019 11:08:42 +0200, Damien Cassou <damien@cassou.me> said:
Damien> Please find attached a patch fixing the default value and type of
Damien> message-make-forward-subject-function.
Damien> + :type '(repeat :tag "List of functions"
Damien> + (radio (function-item message-forward-subject-author-subject)
Damien> + (function-item message-forward-subject-fwd)
Damien> + (function-item message-forward-subject-name-subject)
Damien> + (function))))
I donʼt see how this could work: 'radio allows selecting only one from
the list. How about something like this:
diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el
index 48d79107ea..1a1cb79039 100644
--- i/lisp/gnus/message.el
+++ w/lisp/gnus/message.el
@@ -532,7 +532,7 @@ message-user-organization-file
:group 'message-headers)
(defcustom message-make-forward-subject-function
- #'message-forward-subject-name-subject
+ (list #'message-forward-subject-name-subject)
"List of functions called to generate subject headers for forwarded messages.
The subject generated by the previous function is passed into each
successive function.
@@ -547,10 +547,11 @@ message-make-forward-subject-function
to it."
:group 'message-forwarding
:link '(custom-manual "(message)Forwarding")
- :type '(radio (function-item message-forward-subject-author-subject)
- (function-item message-forward-subject-fwd)
- (function-item message-forward-subject-name-subject)
- (repeat :tag "List of functions" function)))
+ :type '(set :tag "List of functions"
+ (function-item message-forward-subject-author-subject)
+ (function-item message-forward-subject-fwd)
+ (function-item message-forward-subject-name-subject)
+ (repeat :tag "User functions" :inline t (function :tag "Function"))))
(defcustom message-forward-as-mime nil
"Non-nil means forward messages as an inline/rfc822 MIME section.
next prev parent reply other threads:[~2019-09-20 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 9:08 bug#37470: 26.3; [PATCH] Default value and type of message-make-forward-subject-function Damien Cassou
2019-09-20 10:02 ` Robert Pluim [this message]
2019-09-20 10:22 ` Damien Cassou
2019-09-20 12:14 ` Robert Pluim
2019-09-20 17:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y2yjz3o8.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=37470@debbugs.gnu.org \
--cc=damien@cassou.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).