From: Robert Pluim <rpluim@gmail.com>
To: Mike Hamrick <mikeh@muppetlabs.com>
Cc: 38564@debbugs.gnu.org
Subject: bug#38564: 27.0.50; macOS "emacs -nw" git-gutter-mode segfault
Date: Wed, 11 Dec 2019 16:35:33 +0100 [thread overview]
Message-ID: <m2y2viyiwq.fsf@gmail.com> (raw)
In-Reply-To: <m1fthqj3kj.fsf@eidolon.muppetlabs.com> (Mike Hamrick's message of "Wed, 11 Dec 2019 07:15:56 -0800")
tags 38564 fixed
close 38564 27.1
quit
>>>>> On Wed, 11 Dec 2019 07:15:56 -0800, Mike Hamrick <mikeh@muppetlabs.com> said:
Mike> Robert Pluim writes:
>> Iʼm surprised nobody's seen this before.
Mike> I was able to find a couple of references to the bug that were reported
Mike> downstream.
Mike> https://github.com/d12frosted/homebrew-emacs-plus/issues/112
Mike> https://github.com/hlissner/doom-emacs/issues/1170
Ah. Iʼm a bit sad they didnʼt report that back to us. Adding it to
'known upstream bugs' on github doesnʼt really help get things fixed.
>> Right idea, but one layer lower than needed. ns_color_index_to_rgba
>> should not be calling ns_lookup_indexed_color in non-gui mode. Try
>> this instead:
Mike> Your patch does indeed fix the bug for me! It also explains why this
Mike> issue doesn't exist in 26.2, as the ns_color_index_to_rgba function was
Mike> added a little over a year ago. I'm a bit shocked at how quickly my bug
Mike> report reached someone intimately familiar with the underlying code.
I added it, so as the guilty party Iʼm obligated to fix it forever :-)
Thanks for the testing, committed to master as ea84a95bd8 , closing the bug.
Robert
next prev parent reply other threads:[~2019-12-11 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 1:33 bug#38564: 27.0.50; macOS "emacs -nw" git-gutter-mode segfault Mike Hamrick
2019-12-11 10:12 ` Robert Pluim
2019-12-11 15:15 ` Mike Hamrick
2019-12-11 15:35 ` Robert Pluim [this message]
2019-12-11 19:37 ` Alan Third
2019-12-12 7:45 ` Robert Pluim
2019-12-19 19:20 ` Alan Third
2019-12-19 18:03 ` Mike Hamrick
2019-12-19 19:14 ` Alan Third
2019-12-20 11:47 ` Robert Pluim
2019-12-20 20:21 ` Mike Hamrick
2019-12-29 20:41 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y2viyiwq.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=38564@debbugs.gnu.org \
--cc=mikeh@muppetlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).