From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#48494: 28.0.50; [PATCH] AngeFTP fails on macOS 10.14 with GNU inetutils FTP Date: Tue, 25 May 2021 12:33:36 -0700 Message-ID: References: <83mtsss1gn.fsf@gnu.org> <83o8d7rjl8.fsf@gnu.org> <8735uh4ky4.fsf@gmx.de> <87tumxay5b.fsf@gnus.org> <87sg2gqysh.fsf@gmx.de> <878s43nu5h.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22248"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 48494@debbugs.gnu.org, Lars Ingebrigtsen To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 21:34:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llcol-0005aH-H9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 21:34:19 +0200 Original-Received: from localhost ([::1]:38692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llcok-0003QS-J0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 15:34:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llcoU-0003PF-Mp for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 15:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llcoU-00005k-FD for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llcoU-000653-CV for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48494 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48494-submit@debbugs.gnu.org id=B48494.162197122323348 (code B ref 48494); Tue, 25 May 2021 19:34:02 +0000 Original-Received: (at 48494) by debbugs.gnu.org; 25 May 2021 19:33:43 +0000 Original-Received: from localhost ([127.0.0.1]:46895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llcoB-00064W-Ki for submit@debbugs.gnu.org; Tue, 25 May 2021 15:33:43 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:15617 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llco8-00064M-Ay for 48494@debbugs.gnu.org; Tue, 25 May 2021 15:33:43 -0400 Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:a0af:db4e:3957:b65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FqPQ92tgyz3pdpf; Tue, 25 May 2021 12:33:37 -0700 (PDT) In-Reply-To: <878s43nu5h.fsf@gmx.de> (Michael Albinus's message of "Tue, 25 May 2021 09:34:50 +0200") Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207244 Archived-At: --=-=-= Content-Type: text/plain Michael Albinus writes: > Alex Bochannek writes: > > Hi Alex, > >> Follow-up to this. The issue on macOS appears to be caused by inetutils >> picking up libedit for Readline during configuration. Once I installed a >> proper libreadline and configured with the right prefix, the problem was >> resolved. >> >> Adding the -e comment to the docstring still seems sensible to me. > > D'accord. Perhaps you could also add a comment with this fact, and > referring to bug#48494. Sounds good. See below. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/lisp/net/ange-ftp.el b/lisp/net/ange-ftp.el index 04ea809127..3f3a3df8e5 100644 --- a/lisp/net/ange-ftp.el +++ b/lisp/net/ange-ftp.el @@ -949,7 +949,11 @@ ange-ftp-gateway-ftp-program-name :type 'string) (defcustom ange-ftp-ftp-program-args '("-i" "-n" "-g" "-v") - "A list of arguments passed to the FTP program when started." + ;; Clients that use the BSD editline instead of the GNU readline + ;; library may need to disable command line editing. (Bug#48494) + "A list of arguments passed to the FTP program when started. +Some FTP clients may also require the \"-e\" argument, which disables +command line editing." :group 'ange-ftp :type '(repeat string)) --=-=-= Content-Type: text/plain -- Alex. --=-=-=--