From: Rudolf Schlatte <rudi@constantly.at>
To: 68781@debbugs.gnu.org
Subject: bug#68781: [PATCH] Don't fill yaml except comments and block scalars.
Date: Tue, 30 Jan 2024 11:15:34 +0100 [thread overview]
Message-ID: <m2y1c76sah.fsf@eduroam-193-157-190-224.wlan.uio.no> (raw)
In-Reply-To: <m18r49iooh.fsf@constantly.at>
Graham Marlow <graham@mgmarlow.com> writes:
>> Hello Randy, thanks for having a look! Could you tell me which
>> tree-sitter grammar you are using? I'm asking because with the grammar
>> from https://github.com/ikatyang/tree-sitter-yaml I don't see what you
>> describe.
>
> For the record I'm also using this grammar.
>
> Looking at the patch, what do you think about retaining the existing behavior
> (so block_scalars still fill correctly) while inhibiting fill_paragraph for
> everything else as suggested? Originally I retained the existing behavior of
> fill-paragraph just to limit the number of things changed by the patch, not
> because it was working properly. I think blocking the call to fill-paragraph
> for non-block/comment nodes makes sense.
I'm suddenly a bit stressed for time and can't investigate properly for
the next few days why my proposed patch misbehaves under some
circumstances.. And your patch fixes the misbehavior with a minimum of
changes, so I think it's the one that should go in.
Thanks to both of you for working on this!
next prev parent reply other threads:[~2024-01-30 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 13:15 bug#68781: [PATCH] Don't fill yaml except comments and block scalars Rudolf Schlatte
2024-01-28 14:52 ` Rudolf Schlatte
2024-01-29 3:47 ` Randy Taylor
2024-01-29 8:20 ` Rudolf Schlatte
2024-01-29 14:08 ` Randy Taylor
2024-01-30 1:20 ` Graham Marlow
2024-01-30 10:15 ` Rudolf Schlatte [this message]
2024-01-30 19:25 ` Randy Taylor
2024-02-01 10:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y1c76sah.fsf@eduroam-193-157-190-224.wlan.uio.no \
--to=rudi@constantly.at \
--cc=68781@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).