unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 7166@debbugs.gnu.org
Subject: bug#7166: browse-url truncates the given url after an '&'
Date: Fri, 08 Oct 2010 19:24:55 +0200	[thread overview]
Message-ID: <m2wrpsmwbc.fsf@igel.home> (raw)
In-Reply-To: <19630.4837.244794.325438@fencepost.gnu.org> (Glenn Morris's message of "Thu, 7 Oct 2010 14:35:17 -0400")

Glenn Morris <rgm@gnu.org> writes:

> I guess this might fix it:
>
> *** lisp/net/browse-url.el	2010-09-23 06:42:45 +0000
> --- lisp/net/browse-url.el	2010-10-07 18:28:31 +0000
> ***************
> *** 939,945 ****
>     (interactive (browse-url-interactive-arg "URL: "))
>     (call-process "/bin/sh" nil nil nil
>   		"-c"
> ! 		(concat "nohup xdg-open " url
>   			">/dev/null 2>&1 </dev/null")))
>   
>   ;;;###autoload
> --- 939,945 ----
>     (interactive (browse-url-interactive-arg "URL: "))
>     (call-process "/bin/sh" nil nil nil
>   		"-c"
> ! 		(concat "nohup xdg-open " (shell-quote-argument url)
>   			">/dev/null 2>&1 </dev/null")))
>   
>   ;;;###autoload

The use of /bin/sh is completely unnecessary.  The nil for infile and
buffer are already equivalent to the explicit redirections.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





      parent reply	other threads:[~2010-10-08 17:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 13:26 bug#7166: browse-url truncates the given url after an '&' Ken Hori
2010-10-06 17:32 ` Glenn Morris
2010-10-07  5:36   ` Ken Hori
2010-10-07 18:11     ` Glenn Morris
2010-10-07 18:35       ` Glenn Morris
2010-10-08  4:21         ` Ken Hori
2010-10-08 17:24         ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wrpsmwbc.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=7166@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).