From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#29053: 26.0.90: scroller cannot be dragged to bottom of window Date: Tue, 31 Oct 2017 22:12:47 +0100 Message-ID: References: <837eveuosx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1509484334 17201 195.159.176.226 (31 Oct 2017 21:12:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 31 Oct 2017 21:12:14 +0000 (UTC) Cc: 29053@debbugs.gnu.org To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 31 22:12:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9dpL-0003VW-Pj for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Oct 2017 22:12:04 +0100 Original-Received: from localhost ([::1]:47411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9dpT-0002g8-8S for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Oct 2017 17:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9dpN-0002fs-8t for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 17:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9dpK-00060A-43 for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 17:12:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9dpK-000603-0H for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 17:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9dpJ-0007Cz-RV for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 17:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Oct 2017 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29053 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29053-submit@debbugs.gnu.org id=B29053.150948430327681 (code B ref 29053); Tue, 31 Oct 2017 21:12:01 +0000 Original-Received: (at 29053) by debbugs.gnu.org; 31 Oct 2017 21:11:43 +0000 Original-Received: from localhost ([127.0.0.1]:44678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9dp1-0007CO-Es for submit@debbugs.gnu.org; Tue, 31 Oct 2017 17:11:43 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:35891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9doz-0007C6-TK for 29053@debbugs.gnu.org; Tue, 31 Oct 2017 17:11:42 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 25B412259C for <29053@debbugs.gnu.org>; Tue, 31 Oct 2017 21:04:40 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1509483878; x=1510347879; bh=vLiJVDQ81niVn 150ZF/jvqWlxt9zbJSwLCUeQEUH/XY=; b=mcktbNnHuQJaVf4/zB1xwLX2LwHl9 oQIGfSzjkXjAihYR7wUxxUifCHQQWUy5ePpd6dJYWW+iwXZjvmJMTNLMoYnyaqEA x3gNpYpt74WIRdhHVAO2YqsPVdrysQXREAnkDIhL06u7ghQheiIcvMUfcbMgDRGN fSDPkzXv7L/+gU= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ecka0xbmmTv2 for <29053@debbugs.gnu.org>; Tue, 31 Oct 2017 21:04:38 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 0044F22574; Tue, 31 Oct 2017 21:04:36 +0000 (UTC) In-reply-to: (charles@aurox.ch) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139291 Archived-At: Seems that reverting this commit removes the issue: commit e683a2570be6f2e4f8defa4e7ee35a7d87f18918 Author: Alan Third Ref: tags/emacs-26.0.90~2038 Date: Sun May 1 13:04:07 2016 +0200 Implement horizontal scroll bars on NS * lisp/scroll-bar.el (horizontal-scroll-bars-available-p): Remove NS check. * lisp/term/ns-win.el: Remove custom NS scroll-bar handlers and bind scroll-bar mouse clicks to standard handlers. * src/nsterm.h (EmacsScroller): Add 'horizontal' property and rename pixel_height to pixel_length. * src/nsterm.m (x_set_window_size): Remove left-hand scroll-bar code. It caused scroll-bars to be over-drawn and the best working solution appears to be complete removal. (ns_set_horizontal_scroll_bar): Rewrite to handle horizontal scrollers correctly. (ns_set_vertical_scroll_bar): Set width to actual scroller width. (setFrame): Handle horizontal case. (dealloc): Handle horizontal case. (judge): Handle horizontal case. (setPosition): Rename pixel_height to pixel_length. (sendScrollEventAtLoc): Handle horizontal case. (mouseDown): Handle horizontal case and general tidy up of code. (mouseDragged): Handle horizontal case. Call sendScrollEventAtLoc with absolute pixel size instead of ratio. * src/window.h: Remove NS check. macOS 10.6 is probably a special case.