From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#32991: 27.0.50; diff-auto-refine-mode a no-op Date: Tue, 09 Oct 2018 21:15:39 +0200 Message-ID: References: Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1539112207 12165 195.159.176.226 (9 Oct 2018 19:10:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2018 19:10:07 +0000 (UTC) Cc: 32991@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 09 21:10:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9xOM-0002zm-3U for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Oct 2018 21:10:02 +0200 Original-Received: from localhost ([::1]:53452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9xQS-0003kG-Qe for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Oct 2018 15:12:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9xQN-0003kB-1s for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9xQI-0007h3-Ti for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g9xQI-0007gX-PK for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g9xQI-0000TU-Fg for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Oct 2018 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32991 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15391123131809 (code B ref -1); Tue, 09 Oct 2018 19:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Oct 2018 19:11:53 +0000 Original-Received: from localhost ([127.0.0.1]:42567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9xQ9-0000T6-Dn for submit@debbugs.gnu.org; Tue, 09 Oct 2018 15:11:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9xQ8-0000Su-7B for submit@debbugs.gnu.org; Tue, 09 Oct 2018 15:11:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9xQ0-0007EC-T1 for submit@debbugs.gnu.org; Tue, 09 Oct 2018 15:11:46 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39645) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9xPz-0007CL-BB for submit@debbugs.gnu.org; Tue, 09 Oct 2018 15:11:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9xPy-0003ht-Ho for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:11:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9xPt-00074F-SU for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:11:42 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:38514) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9xPt-00072A-IE for bug-gnu-emacs@gnu.org; Tue, 09 Oct 2018 15:11:37 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 4438522891 for ; Tue, 9 Oct 2018 19:15:41 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1539112540; x=1539976541; bh=Gw uSopTayxpwGcBOm02G9LAHG7KB9Z9Pn63HMK0fwwk=; b=wcv/g+oK780MrlzDjn FEy57OPgJRnFym6htzZYOf4iOGBt5dAtWd1tqR5/+2D23GCgi4Cz+FenuvtH0xvI EE/7AAmKDjoI79mja2z+GNiH7ObKBPafZAxt+IIVllzkYDj41g50srmfJNU93o5X 0dcsTGLPK/tBKv/oqL7IpcVgo= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GeeCR37UGhtZ for ; Tue, 9 Oct 2018 19:15:40 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 234A922879; Tue, 9 Oct 2018 19:15:39 +0000 (UTC) In-reply-to: (message from Stefan Monnier on Mon, 08 Oct 2018 17:00:31 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151059 Archived-At: > From: Stefan Monnier > Date: Mon, 08 Oct 2018 17:00:31 -0400 > > >> * lisp/vc/diff-mode.el: Perform hunk refinement from font-lock > > Looks like this commit makes diff-auto-refine-mode a no-op, since > > hunks are now always refined. Is that the intention? > > Yes. Of course, it depends on the value of diff-font-lock-refine. Ok. In that case, do we still need diff-auto-refine-mode? > > Also, with automatic refinement always on, does the following part of > > diff-mode.el still require refining the hunk? > > I believe this is the same question. I'm not sure I understand. If the default value of diff-font-lock-refine results in hunks being automatically refined by font-lock, why should the navigation function possibly re-do the refining already done by font-lock?