From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#73838: 31.0.50; Problems in note_mouse_highlight if -nw Date: Thu, 17 Oct 2024 14:12:03 +0200 Message-ID: References: <86r08goy76.fsf@gnu.org> <86msj3q4t0.fsf@gnu.org> <86iktrpe46.fsf@gnu.org> <86cyjzp9dj.fsf@gnu.org> <867ca7ovob.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73838@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 17 14:14:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1POC-0004Wz-41 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Oct 2024 14:14:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1PNv-0005ea-7y; Thu, 17 Oct 2024 08:13:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1PNt-0005eA-88 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 08:13:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1PNt-00038l-00 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 08:13:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8NU4g8EhFvAVaIGY6xpi8E9i9M78B9PJORcsASdusJE=; b=LZplHQD8W4fI8YeA52wGS/3BMSA+LOIkQp6tauw5E/jFOvLDEwUOZUAO/+msz6o5N1xK0fPGOxyPNVFh97VnQYatCbdr/h7yLp0GSdYqT+uUPwyWCVEqybNYA5IFKxyXyXsJMFoUuRyiMgmcwldhd4GUkodgRxvSwx7SV5DtF9LQTmJhArxAR4Xwx+hMmW87dewL254ZNqqsK2gOpm9TnZr/GLwZhLDtTdq1KTQ9O1VqZY73oq0l/HYMUtkT1Ad0W/IFIAV2N+VjcG2DELjMJLr6htGeOid6kR/3TnhEzU0TR3NCVJvw9K4vYxF/HH799RQ3V9uDDi5FHGEXtbQJdA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1POD-0004ap-OI for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 08:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2024 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73838 X-GNU-PR-Package: emacs Original-Received: via spool by 73838-submit@debbugs.gnu.org id=B73838.172916721617599 (code B ref 73838); Thu, 17 Oct 2024 12:14:01 +0000 Original-Received: (at 73838) by debbugs.gnu.org; 17 Oct 2024 12:13:36 +0000 Original-Received: from localhost ([127.0.0.1]:33650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1PNn-0004Zm-KF for submit@debbugs.gnu.org; Thu, 17 Oct 2024 08:13:35 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:51412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1PNl-0004ZX-H2 for 73838@debbugs.gnu.org; Thu, 17 Oct 2024 08:13:34 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4315abed18aso5397765e9.2 for <73838@debbugs.gnu.org>; Thu, 17 Oct 2024 05:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729167126; x=1729771926; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8NU4g8EhFvAVaIGY6xpi8E9i9M78B9PJORcsASdusJE=; b=N7qcpIxhNAwqs7C+EFmxXslaTJ4P6qJtNgfYymYLXXwlwJ3e3N2n4nZ7FYaRarfXKe RfLYPw6tX2FjcOHa5S60KCbdafoimrmNwbuuiq4G0WapCAyUebJApWvMSNeC31bdGihU gtrV+wvAHpk+XV5PrTZoJ7YM7XeXRfZ+A+y5EwyZ97CVP+eIY7UDhDM03sNvXAjMgeHP ckZMtl8PpFHi7s91WsXiw26ojNFOwcbLKFffCpsvTxR0rvtaCsOyFUCkJanwoMs92gGX jdb2nFKNLPWm8Nx3X22gdg3zHVYGIAG1cFrjU/iIHuscneDX0XiUNnGXFYy2VoxbP9y8 CNjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729167126; x=1729771926; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8NU4g8EhFvAVaIGY6xpi8E9i9M78B9PJORcsASdusJE=; b=T6K6S4yVB+KbEBrLGqf4U/1Fup1nEX6m25zyen89PmQf8A3jaY4QEFe1pJK2EqWih1 MDRJICVGd0ZnR4UryNb/AJWWjQE1FHqp3Ye0Io+yOTfkWauafrUCbckyR8oTC6vpw2b2 22iZ/qZFYqWmNg8Mi0W/C/XPyhSJz7ZFrmRNGS407hEjbQ2/rG1nTN8tYmrDnnLflaC3 2mcwbJeMOvl17Oaqc5DHkbHSqzwGuGWvn1/iP1nMT4XrY6OIzq41Es8HYVEqy9AYQuSD Awv8O7UHJxDsFCzPsPXFex+FZhzIeqX9V9FAeB0azj9hG3Cua7U8itrEnWa95YcUxlhg oG7g== X-Gm-Message-State: AOJu0YzmZhlVtZx6+uBz+jPHa4sYVdG/rEW7ocFJttt6c58KaCp0empB pJqFBHOUPuOFB7mbO0yTi9DIWUHWSAJbyTlQU9eAj8weIdVa166MdZuVbw== X-Google-Smtp-Source: AGHT+IEMXruQaAqCEMTseP41VfWcD7Hdrx4qVFtzEM1j4GZGrw53ihrdt3ncD2pJf8S9QuzKips4iQ== X-Received: by 2002:a05:600c:5251:b0:426:64a2:5362 with SMTP id 5b1f17b1804b1-431255dc80cmr151496045e9.8.1729167126279; Thu, 17 Oct 2024 05:12:06 -0700 (PDT) Original-Received: from pro2 (pd9e36829.dip0.t-ipconnect.de. [217.227.104.41]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43158c61b20sm24227355e9.42.2024.10.17.05.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 05:12:05 -0700 (PDT) In-Reply-To: <867ca7ovob.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Oct 2024 13:44:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293724 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: 73838@debbugs.gnu.org >> Date: Thu, 17 Oct 2024 09:03:13 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > If that's not what you are suggesting, I >> > wonder what is wrong with the current code that we need to make >> > changes which are basically half-solutions. If the problem is access >> > to unrelated memory, that is easy to fix by just adding enough slack >> > to tty_output definition, for example. >>=20 >> You mean by making sizeof (struct tty_output) =3D=3D sizeof (ns_output) = in >> my case, and let it go? Bloodcurdlingly horrible! I don't even want to >> think about it. > > Why is it a problem to add some dummy buffer to a struct? what's so > horrible about that? The reason is to let ASAN build run without > false positives. Well, for me it's not a false positive. ASAN is absolutely right about it says. We are accessing memory that's not there because we are accessing something of the wrong type. Making the memory the memory appear doesn't change the fact that we are still accessing something as the wrong type. I find that horrible, sorry :-). But it doesn't matter. I have what I posted in my branch, so it doesn't prevent me personally from proceeding. > Alternatively, cannot you tell ASAN in some way that this code is > okay? The docs say clang supports an ottribute for that=20 Disabling Instrumentation with __attribute__((no_sanitize("address"))) Haven'tever used that, though, so I don't know if it works.