From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dave Abrahams Newsgroups: gmane.emacs.bugs Subject: bug#8863: 23.3; Strikethrough won't display on MacOS Date: Sat, 02 Jul 2011 22:27:31 -0400 Message-ID: References: <87aade24li.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309661195 18791 80.91.229.12 (3 Jul 2011 02:46:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2011 02:46:35 +0000 (UTC) To: 8863@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 03 04:46:27 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QdChW-0005ia-DB for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2011 04:46:26 +0200 Original-Received: from localhost ([::1]:60872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdChV-0005Uz-Ep for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2011 22:46:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:45577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdChA-0005UI-IB for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 22:46:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdCh8-00012Z-NY for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 22:46:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdCh8-00012V-CN for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 22:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QdCh7-0005dh-NY; Sat, 02 Jul 2011 22:46:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 02:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8863 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130966112220419 (code B ref -1); Sun, 03 Jul 2011 02:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Jul 2011 02:45:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdCgT-0005J3-JO for submit@debbugs.gnu.org; Sat, 02 Jul 2011 22:45:22 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdCgR-00058U-7X for submit@debbugs.gnu.org; Sat, 02 Jul 2011 22:45:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdCgK-0000zw-NJ for submit@debbugs.gnu.org; Sat, 02 Jul 2011 22:45:13 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:46352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdCgK-0000zs-51 for submit@debbugs.gnu.org; Sat, 02 Jul 2011 22:45:12 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:45493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdCgI-0005H9-2R for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 22:45:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdCgG-0000yo-Lj for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 22:45:09 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:50708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdCgG-0000x2-63 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 22:45:08 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QdCgC-0005ND-Pp for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 04:45:04 +0200 Original-Received: from 207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com ([207.172.223.249]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Jul 2011 04:45:04 +0200 Original-Received: from dave by 207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Jul 2011 04:45:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 41 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) Cancel-Lock: sha1:K2uCaG5OtnQQ050KLOCALA4H0eY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 02 Jul 2011 22:46:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47814 Archived-At: on Sat Jul 02 2011, Alp Aker wrote: >> Dave Abrahams writes: >> >> No, but the enclosed 2 patches, together, seem to. Would somebody apply >> these, please? > > I mentioned some problems with Chong Yidong's suggestion, one of which > still applies here: this patch won't work with stretch or image glyphs > (so, e.g., it won't do strike-through on tab characters). > > Also (something I didn't mention in the earlier post), this uses the > same Quartz drawing API as the existing code for underlining, and so > suffers from a problem that exists in that case as well; this kind of > line-drawing is subject to anti-aliasing effects that will cause lines > whose requested thickness is 1 pixel to appear thicker than that > (specifically, the line-drawing commands in question stroke lines so > that they're centered on their specified paths, and so a line whose > thickness is an odd number of pixels is dithered, making it look > thicker). On my screen it's just grayscaled. However, as long as you're in that code, you might also consider whether there's too much rounding off (calls to lrint) going on in there. It certainly did look suspicious to me, but it worked "well enough" that I wasn't going to mess with it. > Last week I promised a patch that would implement strike-through and > overline face attributes and address problems with the existing > implementation of underlining. I'll try to finish that up and post it > tomorrow. Wow, I missed that post and wasted a day implementing this :( Thanks for your work on it. Will you apply this to the 23.3 branch as well as trunk? -- Dave Abrahams BoostPro Computing http://www.boostpro.com