From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree Date: Sat, 22 Nov 2014 13:49:10 +1000 Message-ID: References: <87lhn7s522.fsf@rosalinde.fritz.box> <83lhn789tq.fsf@gnu.org> <87h9xvruan.fsf@rosalinde.fritz.box> <83tx1v6mur.fsf@gnu.org> <87a93nrlql.fsf@rosalinde.fritz.box> <83lhn76iex.fsf@gnu.org> <8761easv3s.fsf@rosalinde.fritz.box> <87r3wytcaa.fsf@rosalinde.fritz.box> <83vbm96dxs.fsf@gnu.org> <87oas0n8sr.fsf@rosalinde.fritz.box> <8361e84yxb.fsf@gnu.org> <87fvdcmpeg.fsf@rosalinde.fritz.box> <83bno0tjjc.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416628228 11268 80.91.229.3 (22 Nov 2014 03:50:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Nov 2014 03:50:28 +0000 (UTC) Cc: 19102@debbugs.gnu.org, Stephen Berman To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 22 04:50:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xs1iI-0008FH-Ap for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Nov 2014 04:50:22 +0100 Original-Received: from localhost ([::1]:43419 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xs1iH-0006Dr-Pa for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 22:50:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xs1i8-00067J-E0 for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 22:50:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xs1i1-0002Ab-2W for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 22:50:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xs1i0-0002AN-VS for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 22:50:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xs1i0-0003wq-EO for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 22:50:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Nov 2014 03:50:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19102-submit@debbugs.gnu.org id=B19102.141662816815100 (code B ref 19102); Sat, 22 Nov 2014 03:50:04 +0000 Original-Received: (at 19102) by debbugs.gnu.org; 22 Nov 2014 03:49:28 +0000 Original-Received: from localhost ([127.0.0.1]:41372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xs1hP-0003vT-Kd for submit@debbugs.gnu.org; Fri, 21 Nov 2014 22:49:28 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39798) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xs1hJ-0003vG-Bi for 19102@debbugs.gnu.org; Fri, 21 Nov 2014 22:49:25 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 912972064C for <19102@debbugs.gnu.org>; Fri, 21 Nov 2014 22:49:20 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 21 Nov 2014 22:49:20 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=tilk.co; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=PsTkXO0CA5Tk XHXBHL7OIxOX8iI=; b=pa8duE0da099WJZ4/zndmrqY/lnYpgjsuW99MRLOgCKG ocjLC9tpah3+aypv/2dO42m9TWnVdurfC7cUJNSEmS66s3dF5xKS8YSqz8kXTU3e NpKOgZuBO4KWp8XkwaoPZFzGD1CvP92xhHAmoq8byQ+/m5ANiBj4YRWWvb2Nvjo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=PsTkXO0CA5TkXHXBHL7OIxOX8iI=; b=QpZAK3PSPFEmEvDi0AOz HunnDKPff3BHESPATQ5cLkObIBv3Ofg+NqLi01uAEAkbADuoEnHTku75tRKaeV3r K3dMw8fQ+0dCgWv3O24dZwW4Sp/YzYJEd3AdQudrMSWvB/ZYCfiD5AfsZGfxwu+u 7LRHChJoHIfcDX76gECiZu0= X-Sasl-enc: 54HapnOdhEpIHuIB9wtiNoC6HbEQiZ1Lh3TA5N8ujso3 1416628159 Original-Received: from Paul-Rankins-MacBook-Pro.local (unknown [202.0.190.43]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E1606800EC; Fri, 21 Nov 2014 22:49:18 -0500 (EST) In-reply-to: <83bno0tjjc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96413 Eli Zaretskii writes: >> I think that, once the non-file buffer case is taken into account (and >> not doing means moving a subtree can corrupt the outline by putting two >> headers on the same line), the cleanest fix is basically the one Paul >> Rankin proposed in his last post. I've attached it as a diff against >> emacs-24, where I assume the fix should be committed (I added a comment >> and tweaked the function Paul posted to avoid irrelevant changes to the >> current code, and also restricted the error handling by making it a >> user-error and having it signal only when the user attempts to move over >> a higher outline level, avoiding an inappropriate message at bob or >> eob). Does this patch qualify as a tiny change, or does Paul have a >> copyright assignment on file (I don't have access to the file)? > > I don't see his assignment. IMO, this patch is borderline wrt being > "tiny"; I'll let Stefan judge. If it doesn't qualify as tiny, I'm happy to say Stephen took some unofficial inspiration from some errant suggestion from me and wrote the code all by himself, ergo copyright is all his :) -- Paul W. Rankin http://www.paulwrankin.com