From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#23856: [PATCH] Remove separate pool for popup dialogs (bug#23856) Date: Sun, 17 Jul 2016 22:20:40 +0100 Message-ID: References: <20160629193222.GA95960@breton.holly.idiocy.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468790489 18128 80.91.229.3 (17 Jul 2016 21:21:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Jul 2016 21:21:29 +0000 (UTC) Cc: 23856-done@debbugs.gnu.org To: Alf =?UTF-8?Q?Lerv=C3=A5g?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 17 23:21:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOtV1-0007bd-DV for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jul 2016 23:21:19 +0200 Original-Received: from localhost ([::1]:43133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOtUx-0003Vx-1M for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jul 2016 17:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOtUo-0003VY-5k for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 17:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOtUk-0006X8-1L for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 17:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOtUj-0006Wy-TC for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 17:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bOtUj-0005P9-Pv for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 17:21:01 -0400 Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2016 21:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Mail-Followup-To: 23856@debbugs.gnu.org, alan@idiocy.org, alf@lervag.net Original-Received: via spool by 23856-done@debbugs.gnu.org id=D23856.146879044420740 (code D ref 23856); Sun, 17 Jul 2016 21:21:01 +0000 Original-Received: (at 23856-done) by debbugs.gnu.org; 17 Jul 2016 21:20:44 +0000 Original-Received: from localhost ([127.0.0.1]:54883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOtUS-0005OS-Is for submit@debbugs.gnu.org; Sun, 17 Jul 2016 17:20:44 -0400 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:37890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOtUR-0005OG-Cb for 23856-done@debbugs.gnu.org; Sun, 17 Jul 2016 17:20:43 -0400 Original-Received: by mail-wm0-f41.google.com with SMTP id o80so92617959wme.1 for <23856-done@debbugs.gnu.org>; Sun, 17 Jul 2016 14:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gm4f1fSLP9VMW9NZH9C6LZHALt9xBHCG42a3JH3mWdI=; b=r62pU+4e+5Rn2k6cMfSMWS8EHp51NsK6CWFdG8gKwthzMGu6gBzlrWqDbsPwhsMMyS sfDNhA98lnaLsstIRtxnpqvlcEKomTAgjtW7NQemzxpSc7qGjSEzDc1IlpliX+dp+yXl XGyi8bKQvSLGyATWtSojSFGCkSxUZKcuAJc3waXNFZ1UYfFXM7Dxv/O0XaaaH7WSDYzi 4+E6WXFTm1pq2OHaWSz47bkYPeNefgRqedbr5CYC91g5TTSFao3acWG4vFjnCAjtjRUc ZYWNAq4S7+QWKLfGucRt5h+w/cMIMRPk2ibSlJJHac2Oa3UHCFcUnTutmuEw5EeAH4Ik txgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=gm4f1fSLP9VMW9NZH9C6LZHALt9xBHCG42a3JH3mWdI=; b=myyTP8Zf89VvkyNunk91vF8KFvklDzU9XMzMZBLyh+RQVXqtCyZji4fnYjJqWjGEsa 5CofF9NH0C7cNI1BaQOxBzmduoFDajvCGDtg1rlN4fGEe6jp5k+IjhatRp9gMwL1vjmR N8JCVsEVLyxMGHXzv8XLpccDlZUzvjuvzD9DdtkKjOSHBQ6mC4zBP9vBq20gcdGn+s83 lOEWrxpSZSidiOWq8qsYTtq11tzfxPdzkqT62zGrIlUttWxUEiHfmZ+GQTYRuO9FEeX3 QWQSnV2PAuVTIqlJMDpobaP1Baj2UCRTyqWZ3yrmt2LLjcRLd14g9y3AfyF0I1qQHc+t wnfw== X-Gm-Message-State: ALyK8tKWidflzAxa7zSbMMMjG8NVITEO+1on3idBx9pN7U5ndx30s/IQIszgtbTz2uIP0Q== X-Received: by 10.28.96.11 with SMTP id u11mr34751687wmb.5.1468790437644; Sun, 17 Jul 2016 14:20:37 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-5cc4-ba14-a0d0-bdac.holly.idiocy.org. [2001:8b0:3f8:8129:5cc4:ba14:a0d0:bdac]) by smtp.gmail.com with ESMTPSA id u125sm11401182wmg.22.2016.07.17.14.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Jul 2016 14:20:37 -0700 (PDT) In-Reply-To: <20160629193222.GA95960@breton.holly.idiocy.org> (Alan Third's message of "Wed, 29 Jun 2016 20:32:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121197 Archived-At: Alan Third writes: > I'm unsure what the purpose of this autorelease pool is. I guess it's > supposed to be so that the dialog object always get released > correctly, but it seems to be broken. > > I've just removed it, which I guess may introduce a memory leak, but I > don't know how to check. I've tried checking this with "leaks" and it's coming back clean, so I've pushed it to master. -- Alan Third