From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Date: Thu, 05 Nov 2020 10:05:29 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 44420@debbugs.gnu.org To: Pankaj Jangid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 05 09:06:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaaHa-0008Ed-2v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Nov 2020 09:06:10 +0100 Original-Received: from localhost ([::1]:33906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaaHY-000745-A8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Nov 2020 03:06:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaaHS-00073z-2Y for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 03:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaaHR-0002yd-PY for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 03:06:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kaaHR-00036D-Jv for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 03:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Nov 2020 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44420 X-GNU-PR-Package: emacs Original-Received: via spool by 44420-submit@debbugs.gnu.org id=B44420.160456354011887 (code B ref 44420); Thu, 05 Nov 2020 08:06:01 +0000 Original-Received: (at 44420) by debbugs.gnu.org; 5 Nov 2020 08:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:51558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaaH6-00035e-M5 for submit@debbugs.gnu.org; Thu, 05 Nov 2020 03:05:40 -0500 Original-Received: from mail-lf1-f48.google.com ([209.85.167.48]:33727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaaH4-00035Q-2Z for 44420@debbugs.gnu.org; Thu, 05 Nov 2020 03:05:39 -0500 Original-Received: by mail-lf1-f48.google.com with SMTP id l2so1000556lfk.0 for <44420@debbugs.gnu.org>; Thu, 05 Nov 2020 00:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HtFZU8eGAEFEx/7xfNPP12jbcWdSJnDu2Mh6nE9rDO0=; b=BdnRyXzGCLytkBcsVFSWE14f96g2cU1dIw5waA+B1UZgx9ohC3zas++GumzFVfAEvm RLx1SPMkj454RdcAaSuxplFvS+dZQ305rELV9m3CtzcXOaiIeZlEkdT39Nimuk8ph9Zb z9ZrimYcryKhS8Fxy4xCNc8CraR+JAtHqrdhX0I16mb7fHUdNdaZlmEuxwYSn/tWI5ii 6apdOiYpvNPsUOJTBWrQxo1YYSkQuRTJ8vfW5c8P1d2iJCcV1fN0ZmECjJjfZ/zvYqJv mEJZhtpSxlb94VSZkaPY5dc+YnRnmYFdALHkxR3MiaAhSCYzQoQqP3h3IIUyR7YxDfqd Xu9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HtFZU8eGAEFEx/7xfNPP12jbcWdSJnDu2Mh6nE9rDO0=; b=gIt/za9N1o7czbM+t/C+FalIH3605ZUxeJx7EeXF9Y8Svdju+QbGaC1OaAh1eoSIme vl9r6kMbPzty9OqnTScwYuuoBIfMmIuwmE1nlzBp8U4DqSgPGfMxmnHgbRQOySUFQrQ+ p5Gk+onhKXqAo7ZOaT/glLkbctzukoZ6jiryAavl2mraEaFcJHjDBu+qx3cKxn1webOs bgj3ijLG5ALJM6Z+ujUQbPEKGKCIlLH7u++yAUkcj+EwtE0unwfa8ssCP+4w+2jXuxz1 F+YMCtH5T6UiPeUzJGIEOYf9QwU+jB8JgicxARdm0Do5dNiwpKQnGnSsO+knNT1gxqw/ fUmg== X-Gm-Message-State: AOAM532Ocb9j8f6O9eGUtIy7B8C3RVVEtKCgdNT2DVjfAIM9sLidyMGE +a/VJmROrG2quw3Liif6TLohEq6xFtQ= X-Google-Smtp-Source: ABdhPJyQ4ClKzQpIfqdqcuptmIdYD9JAzIgZ+ZPNkFZs50ybkW+6ZS46CvKINC4qnsyLkZMxgve4fw== X-Received: by 2002:a05:6512:3052:: with SMTP id b18mr444715lfb.505.1604563531412; Thu, 05 Nov 2020 00:05:31 -0800 (PST) Original-Received: from muffinmac ([91.206.110.192]) by smtp.gmail.com with ESMTPSA id q8sm80158ljg.105.2020.11.05.00.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 00:05:30 -0800 (PST) In-Reply-To: (Pankaj Jangid's message of "Tue, 03 Nov 2020 23:41:04 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192702 Archived-At: Pankaj Jangid writes: > Andrii Kolomoiets writes: > >> See docstring of the `vc-deduce-fileset`: >> >> If the current buffer is in `vc-dir' or Dired mode, FILESET is the >> list of marked files, or the current directory if no files are >> marked. > > Got it. But the second clause `or the current directory if no files are > marked' is not accurate. Because in that case `i' (vc-register) works if > the point is on an untracked item. Indeed. > Wait... is `vc-deduce-fileset' relevant for `vc-register'? I don't > know. Yes. `vc-register` is calling `vc-deduce-fileset` right after `interactive`. >> Including file name in the "File already registered" message may help to >> understand whats going on though. > > This could be a long list. We can just say "Marked file(s) already > registered". Files in the list are checked one by one and error is returned for the first registered file. IMO filename will fit well in the error message.