From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#75451: scratch/igc: Enable CHECK_STRUCTS Date: Thu, 09 Jan 2025 06:09:35 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13228"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd Moellmann , 75451@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 06:10:27 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVkoN-0003IR-Fn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 06:10:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVko0-00064t-2E; Thu, 09 Jan 2025 00:10:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVkny-00064W-BU for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 00:10:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVkny-0003Rk-2Y for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 00:10:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=UnRcF9cFYqKoqWqzTbBnZ5ni3F/1qBs5xvxTKqEDuHQ=; b=CqFlsHDT2to8YSKRnBfIpUCl9OdJ6gnA6Sd+2RaLA0sg1CucJ6l2VupDgZDp1okSSg0isOPF0tF7VubAbGenGfhAFmSd6lgDWeMRdesiLZyEIazP3NhTLFVcj43PiQeN+FXIYiVo5kPbMBbgG04es6vbGDUWJSkij8TxPtiT+DI2JqTLb6wdx6u3+r51vYAN25AFVQNPjGM7vEAA0T6lF01JU6MzzXix5PtUjYZfbumcDg4vIuZTPl8Auv2C5iaagmEfDuuS0IjLNoI7rQ1xE+H2MTTv1ACMecRaZUhORzMV/j8phWoffRWefzVNmyjffqVMws3Ut8kqOLL3Cm65lg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVknx-0008NY-Rb for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 00:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 05:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75451 X-GNU-PR-Package: emacs Original-Received: via spool by 75451-submit@debbugs.gnu.org id=B75451.173639938732167 (code B ref 75451); Thu, 09 Jan 2025 05:10:01 +0000 Original-Received: (at 75451) by debbugs.gnu.org; 9 Jan 2025 05:09:47 +0000 Original-Received: from localhost ([127.0.0.1]:49983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVknj-0008Ml-0z for submit@debbugs.gnu.org; Thu, 09 Jan 2025 00:09:47 -0500 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:60684) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVkng-0008MP-Sk for 75451@debbugs.gnu.org; Thu, 09 Jan 2025 00:09:45 -0500 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4361f664af5so6514795e9.1 for <75451@debbugs.gnu.org>; Wed, 08 Jan 2025 21:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736399378; x=1737004178; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UnRcF9cFYqKoqWqzTbBnZ5ni3F/1qBs5xvxTKqEDuHQ=; b=fL5SBcI9Byx3ICdFZRIpbjW7lqbdR/KHs5ryNH/5RZ3rWR1WuEiMPhMT9fdxpYSMRO CPj2dnY9w0hY4Tyfiyf5fRpSuQ42LLgRnTJ6fkLNgwWoKj+zyvLdVC++f6j6KWhopdwy tD5y4vnxCwpKzBpwJ1BaLCBEGuj+baELHa5iC3nhFdLIPTOOXnM3XpPQkeJkl+8terOq +55UQLXY5aqGJKUI8+Nien57pYlzr+Z1DaDwDxttcVWUtsT3OrLqRclOdhfWL8BvdqBc gr7l+ImVKRNAjnCnvihnQPXAPPV0Z+kdECAikHKH1wDw+VJPCUIyIN3iDjkgh44me3S9 pFYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736399378; x=1737004178; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UnRcF9cFYqKoqWqzTbBnZ5ni3F/1qBs5xvxTKqEDuHQ=; b=Fuux4bAP7rEeiH+B1n6XUXAmpori4mEOBMJ5U0EutSWyrIB/My+TIDlAuiqXCr+dIV s9CdoIlUV3nKXN0UCDxhhMSZ1VRteZ0lLaaVjwLo91Je9rJHHCqE2u10MZIElg300TAp jRp4/xR2cD+zW3ZpGbD+SQU1iwKHNA8g25kSHHSlFJsZCKVJ73S0Ifeb/UREZgMXeqLm samrra2J+aaLBgrQhDE3gOw07b6BDge89OTx4u1oTm7oTlEaNNNWkpCa8ZWYkqAbSb9+ lddW0zaiR/+U1u6qCUyqqFngVFwspOmAOtSX6XXpGhJ53drkjsxxkX09OwnH3LVSnyax TV6g== X-Gm-Message-State: AOJu0Yx42/TVfqXTBLmDBxWD7A5GbU34mnhwKCgQUcvodZ661LNL4fBM Up3qvhkInEqnDfXF69PDjcOhUxOe0dHe3yc+ZXP/fxvPKKvAE2Gy X-Gm-Gg: ASbGncuvLH4Ob3+CGzVCPc+F/J87pMPZLAuEE5+v64aQM+/EtDNuHJV/Ou8C2HGpRDU xIMrVC+PLuglVIGEaDnWxGn6CGAIF9vTQjw85/9KEqiEx+c2vpYL0tt2Si1N9MlffusRVnohsSL 94XWqV3WEP0y2sLg8VEVx17OQv4vtCXIkxKqJjfSsHnzSOcq2ToaFfCPH+phF9Sj4qJEbOacnhQ IVzP2knts7Uth6HRim49fFZ8gfEVbGXLGmyCRag//mx2MLV95TYgWOah+r3wRgfQh2VwwJhoUHN DPw0QFYgtt5lqymdxy+mt/iAhTDUKtI2GdT4XKVu/VpIcZO3VIXJunLj1F809eB4wg== X-Google-Smtp-Source: AGHT+IG6p9va8h6E8JR6FpsbJIJVD8GMAL0NQNxisKEIlbeSUdcFbfnRyhDeVnnpg5x7yshE0MbiOQ== X-Received: by 2002:a5d:5986:0:b0:385:e37a:2a56 with SMTP id ffacd0b85a97d-38a8733a214mr4628355f8f.52.1736399378249; Wed, 08 Jan 2025 21:09:38 -0800 (PST) Original-Received: from pro2 (p200300e0b7182e00ad06de2bb2fec9f1.dip0.t-ipconnect.de. [2003:e0:b718:2e00:ad06:de2b:b2fe:c9f1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1ca9sm680682f8f.92.2025.01.08.21.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 21:09:37 -0800 (PST) In-Reply-To: (Stefan Kangas's message of "Wed, 8 Jan 2025 21:57:06 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298802 Archived-At: Stefan Kangas writes: > Severity: wishlist > > Gerd, how do you feel about the below change? There's no rush to make > this change if it's inconvenient for you, but since you use IN_MY_FORK > elsewhere, I figured that it might be okay for you here also? > > If it's too much trouble, let's just revisit this later. This bug > report will serve as a reminder, if we just lave it open. > > diff --git a/src/igc.c b/src/igc.c > index 079b6a90ac6..b03c64a52b8 100644 > --- a/src/igc.c > +++ b/src/igc.c > @@ -76,8 +76,7 @@ > # error "HAVE_PDUMPER required" > #endif > > -#if 0 /* Not yet because that make transfer between GNU and my fork > - painful. */ > +#ifndef IN_MY_FORK > #ifdef CHECK_STRUCTS > # include "dmpstruct.h" No no, it's no trouble. Thanks for working on this! I'd even go a step further and remove the whole #if. I think it's more useful nowadays to have the checks than to make patching easier. (BTW, the contents of the #if might be out of date, not sure if we meanwhile fix/scan additional structs.)