From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dave Abrahams Newsgroups: gmane.emacs.bugs Subject: bug#8891: 23.3; save-buffer messages about writing files that may not be written Date: Sun, 03 Jul 2011 16:51:48 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309726343 22661 80.91.229.12 (3 Jul 2011 20:52:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2011 20:52:23 +0000 (UTC) Cc: 8891@debbugs.gnu.org To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 03 22:52:19 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QdTeN-0000sa-1C for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2011 22:52:19 +0200 Original-Received: from localhost ([::1]:37505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdTeM-0008UJ-Dv for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2011 16:52:18 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:55198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdTe7-0008UC-Mq for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 16:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdTe6-000386-I0 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 16:52:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdTe6-000382-CZ for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 16:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QdTe5-0000dY-Qw; Sun, 03 Jul 2011 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8891-submit@debbugs.gnu.org id=B8891.13097263192439 (code B ref 8891); Sun, 03 Jul 2011 20:52:01 +0000 Original-Received: (at 8891) by debbugs.gnu.org; 3 Jul 2011 20:51:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdTe2-0000dI-L8 for submit@debbugs.gnu.org; Sun, 03 Jul 2011 16:51:58 -0400 Original-Received: from mail-qw0-f44.google.com ([209.85.216.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdTe0-0000d7-PY for 8891@debbugs.gnu.org; Sun, 03 Jul 2011 16:51:57 -0400 Original-Received: by qwc23 with SMTP id 23so2301121qwc.3 for <8891@debbugs.gnu.org>; Sun, 03 Jul 2011 13:51:51 -0700 (PDT) Original-Received: by 10.224.2.201 with SMTP id 9mr4362299qak.120.1309726309890; Sun, 03 Jul 2011 13:51:49 -0700 (PDT) Original-Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com [207.172.223.249]) by mx.google.com with ESMTPS id g11sm4267105qcm.15.2011.07.03.13.51.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 03 Jul 2011 13:51:49 -0700 (PDT) Original-Received: by pluto.luannocracy.com (Postfix, from userid 501) id 1539768698D; Sun, 3 Jul 2011 16:51:48 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 03 Jul 2011 22:31:45 +0200") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 03 Jul 2011 16:52:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47864 Archived-At: on Sun Jul 03 2011, Lars Magne Ingebrigtsen wrote: > Dave Abrahams writes: > >> Yes... until `save-buffer' calls `basic-save-buffer' which invokes >> `write-file-functions', one of which decides to override the notion of >> "modified-ness" when it ascertains that the contents have not actually >> changed. So modp tells the truth at the time it's checked, but IMO it's >> checked too early. > > Right. So perhaps `basic-save-buffer-2' is the right place to output > the message? I've grepped through the .el files, and there doesn't seem > to be any other callers other than the straight line down from > `save-buffer'. > > Opinions, anybody? To be ridiculously general, we could observe that some `write-file-functions' probably /do/ write the file (their own way) before returning non-nil, and in those cases, the message is appropriate. So we could say that a `write-file-function' can return a special symbol like `not-really-modified' or `do-not-write' to suppress the message. -- Dave Abrahams BoostPro Computing http://www.boostpro.com