From: Chunyang Xu <mail@xuchunyang.me>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25485@debbugs.gnu.org
Subject: bug#25485: 25.1; Having trouble setting --time-style in dired-listing-switches
Date: Sat, 28 Jan 2017 09:01:15 +0800 [thread overview]
Message-ID: <m2tw8kro9w.fsf@xuchunyang.me> (raw)
In-Reply-To: <837f5g1udp.fsf@gnu.org>
Eli Zaretskii writes:
>> From: Chunyang Xu <mail@xuchunyang.me>
>> Cc: 25485@debbugs.gnu.org
>> Date: Fri, 20 Jan 2017 01:20:45 +0800
>>
>>
>> Eli Zaretskii writes:
>>
>> >> From: Chunyang Xu <mail@xuchunyang.me>
>> >> Date: Thu, 19 Jan 2017 22:34:31 +0800
>> >>
>> >> I want to custom the file timestamps used in dired through the option:
>> >>
>> >> --time-style='+%_m月 %d %H:%M'
>> >>
>> >> then I adjust `dired-listing-switches' accordingly:
>> >>
>> >> (setq dired-listing-switches "-al --time-style='+%_m月 %d %H:%M'")
>> >>
>> >> However, it doesn't work, it signals an error, here is the Backtrace:
>> >
>> > Isn't --time-style a GNU ls extension? You are on Darwin, so do you
>> > have GNU ls installed? What happens if you use that option from the
>> > shell prompt?
>>
>> Yes, and yes, and I have set shell and Emacs to use GNU ls, thus in
>> shell (via M-x shell) it works like expected:
>
> Your setting of dired-listing-switches assumes that the 'ls' command
> will be run by a shell: you use shell quoting. But that's not what
> Dired does, it in most cases invokes 'ls' directly, and for that it
> needs to split the switches into individual options. It does that by
> calling split-string on the value of dired-listing-switches, which of
> course knows nothing about the '..' quoting. That's why 'ls' fails:
> it gets the --time-style option split between several separate
> command-line arguments.
>
> What this means is that currently Dired doesn't support switches that
> include embedded whitespace at all. One way of lifting at least some
> of that limitation is the simple patch below; it will require you to
> format your switches like this:
>
> (setq dired-listing-switches "-al \"--time-style=+%_m月 %d %H:%M\"")
>
> The function combine-and-quote-strings can help in producing the
> correct format. Given that we document this, is this an acceptable
> solution? (It won't work on MS-Windows, but the default there is not
> to call external programs at all, so I think it's not a terrible loss,
> for those Windows users who set up their systems to use 'ls'.)
>
> Here's the proposed patch; comments are welcome:
>
> diff --git a/lisp/files.el b/lisp/files.el
> index 25392fd..0a7b6a2 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -6572,7 +6572,7 @@ insert-directory
> (unless (equal switches "")
> ;; Split the switches at any spaces so we can
> ;; pass separate options as separate args.
> - (split-string switches)))
> + (split-string-and-unquote switches)))
> ;; Avoid lossage if FILE starts with `-'.
> '("--")
> (progn
I have tried the patch and changed dired-listing-switches accordingly,
it works now. Thus the solution is acceptable to me.
My first thought was, we can make dired-listing-switches also accepts a
list of arguments, then something like this
(setq dired-listing-switches
(list "-al" "--time-style=+%_m月 %d %H:%M"))
should just work. But it will require much more work and I have no idea
how 'C-u M-x dired-sort-toggle-or-edit' can work as usual.
next prev parent reply other threads:[~2017-01-28 1:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 14:34 bug#25485: 25.1; Having trouble setting --time-style in dired-listing-switches Chunyang Xu
2017-01-19 16:11 ` Eli Zaretskii
2017-01-19 17:20 ` Chunyang Xu
2017-01-20 7:43 ` Eli Zaretskii
2017-01-27 13:53 ` Eli Zaretskii
2017-01-28 1:01 ` Chunyang Xu [this message]
2017-01-28 7:22 ` Eli Zaretskii
2017-02-04 10:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tw8kro9w.fsf@xuchunyang.me \
--to=mail@xuchunyang.me \
--cc=25485@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).